Skip to content

chore: create separate modules for each demo page - #15498

Merged
mmalerba merged 3 commits into
angular:masterfrom
mmalerba:fix-demo
Mar 15, 2019
Merged

chore: create separate modules for each demo page#15498
mmalerba merged 3 commits into
angular:masterfrom
mmalerba:fix-demo

Conversation

@mmalerba

@mmalerbammalerba commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@mmalerbammalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 15, 2019
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2019
crisbeto
crisbeto reviewed Mar 15, 2019
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but is there any context as to why we're doing it?

Comment threadsrc/dev-app/dev-app-chrome/dev-app-chrome-module.ts Outdated
@andrewseguin

andrewseguin commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

LGTM

@mmalerba

mmalerba commented Mar 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@crisbeto This is a step toward having lazy-loadable routes, which will make our dev-app load faster and give us a place to reproduce lazy-loading bugs reported by users

@mmalerbammalerba added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2019
crisbeto
crisbeto approved these changes Mar 15, 2019
View reviewed changes

@crisbetocrisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba
mmalerba merged commit 3b0f7fc into angular:masterMar 15, 2019
mmalerba added a commit that referenced this pull request Mar 18, 2019
@mmalerba
chore: create separate modules for each demo page (#15498)
f503353
mmalerba added a commit that referenced this pull request Mar 18, 2019
@mmalerba
chore: create separate modules for each demo page (#15498)
54733f0
@mmalerbammalerba mentioned this pull request Mar 19, 2019
Merged
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Sep 10, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Sep 10, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes
@andrewseguinandrewseguinAwaiting requested review from andrewseguin
@devversiondevversionAwaiting requested review from devversion
@jelbournjelbournAwaiting requested review from jelbourn
@josephperrottjosephperrottAwaiting requested review from josephperrott

Assignees

@andrewseguinandrewseguin

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaroundtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmalerba@andrewseguin@crisbeto@googlebot