Uh oh!
There was an error while loading. Please reload this page.
chore(dev-app): add lazy loading - #15522
Merged
Merged
Conversation
mmalerba
requested review from
crisbeto, devversion, jelbourn and josephperrott
as code ownersMarch 18, 2019 22:43
CaerusKaru
commented
Mar 18, 2019
Member
Getting a |
devversion
commented
Mar 18, 2019
Member
I got the same today when I wanted to switch the dev-app to Bazel with AOT compilation. Even though it didn't use lazy-loading, I hit the same issue. That's pretty weird. |
mmalerba
commented
Mar 19, 2019
ContributorAuthor
I probably missed a module dependency in #15498, I'll add the fix to this PR |
mmalerba
commented
Mar 19, 2019
ContributorAuthor
It looks like the issue was due to the router-outlet being outside the tree where the |
devversion added a commit
to devversion/material2
that referenced
this pull request
Mar 20, 2019
This reverts commit 44f185b.
jelbourn pushed a commit
that referenced
this pull request
Mar 21, 2019
* Revert "Revert "chore(dev-app): add lazy loading (#15522)"" This reverts commit 44f185b. * build: serve ivy dev-app with lazy loading * Updates the Ivy script/build pipeline to support lazy-loading with the dev-app. * Removes duplicate lazy routes (otherwise causes error within rollup) * Ensures Ivy Angular install script ensures clean Ivy packages are installed * Ensures Ivy `build.sh` script works if Gulp is not installed globally.
andrewseguin pushed a commit
that referenced
this pull request
Mar 25, 2019
* dev-app: add lazy loading * fix snackbar RTL * fix lint * fix aot build
JoostK pushed a commit
to JoostK/components
that referenced
this pull request
May 7, 2019
This reverts commit 1dce080.
JoostK pushed a commit
to JoostK/components
that referenced
this pull request
May 7, 2019
* Revert "Revert "chore(dev-app): add lazy loading (angular#15522)"" This reverts commit 44f185b. * build: serve ivy dev-app with lazy loading * Updates the Ivy script/build pipeline to support lazy-loading with the dev-app. * Removes duplicate lazy routes (otherwise causes error within rollup) * Ensures Ivy Angular install script ensures clean Ivy packages are installed * Ensures Ivy `build.sh` script works if Gulp is not installed globally.
JoostK pushed a commit
to JoostK/components
that referenced
this pull request
Jul 9, 2019
This reverts commit 1dce080.
JoostK pushed a commit
to JoostK/components
that referenced
this pull request
Jul 9, 2019
* Revert "Revert "chore(dev-app): add lazy loading (angular#15522)"" This reverts commit 44f185b. * build: serve ivy dev-app with lazy loading * Updates the Ivy script/build pipeline to support lazy-loading with the dev-app. * Removes duplicate lazy routes (otherwise causes error within rollup) * Ensures Ivy Angular install script ensures clean Ivy packages are installed * Ensures Ivy `build.sh` script works if Gulp is not installed globally.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demo: https://mmalerba-demo1.firebaseapp.com/