feat(progress-spinner): create progress-spinner based on MDC Web by annieyw · Pull Request #20048 · angular/components

annieyw · 2020-07-20T22:14:07Z

No description provided.

crisbeto · 2020-07-23T18:25:45Z

One more thing: it doesn't look like the server-side rendering check was set up for the new component.

jelbourn · 2020-07-23T21:57:47Z

+ </div>
+ </div>
+ </div>
+</div>


Do we know why the MDC spinner is so much more complicated than our existing one? I'm surprised that this has four SVGs when the current spinner uses just one (with two circle elements)

I think it may be because the MDC spinner supports 4 colors but I'm not sure

Four colors at the same time? It would be good to just check in with them to get some background so that we know why it's built this way

jelbourn · 2020-07-24T23:33:30Z

+ </div>
+ </div>
+ </div>
+</div>


Four colors at the same time? It would be good to just check in with them to get some background so that we know why it's built this way

…ss-spinner

mmalerba

LGTM

jelbourn

LGTM- we can figure out more about the multiple svgs as we go

…owup)

…on MDC Web (#20048) * add files for MDC-based MatProgressSpinner * add demo of mdc-based MatProgressSpinner at localhost:4200/mdc-progress-spinner * copy MDC DOM and add MDC styles * set up MDC foundation for MDC-based MatProgressSpinner * (wip) add adapter and fill in API * copy over existing demo to MDC-based demo * serverside rendering, refactor * add tests (adapter class wip) * remove separate class for MatSpinner * add e2e tests * add harness * add user documantation README * add codeowner, theme dep * address CI failures * export MatSpinner as const to avoid build error * fix missing e2e import * fix nits * remove changes to _all-themes to keep PR merge-safe (add back in followup) (cherry picked from commit 294b8ee)

angular-automatic-lock-bot · 2020-09-26T00:10:16Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2020

annieyw force-pushed the mdc-progress-spinner branch 3 times, most recently from ca84a45 to bcac8f0Compare July 21, 2020 23:22

annieyw requested review from andrewseguin, crisbeto, jelbourn and mmalerba July 21, 2020 23:24

annieyw marked this pull request as ready for review July 22, 2020 16:52

annieyw requested a review from devversion as a code owner July 22, 2020 16:52

annieyw requested a review from a teamJuly 22, 2020 16:52

crisbeto reviewed Jul 23, 2020
View reviewed changes

mmalerba reviewed Jul 23, 2020
View reviewed changes

jelbourn reviewed Jul 23, 2020
View reviewed changes

annieyw force-pushed the mdc-progress-spinner branch from 1a7ef3e to 69605dcCompare July 24, 2020 19:30

mmalerba reviewed Jul 24, 2020
View reviewed changes

Comment threadsrc/material-experimental/mdc-progress-spinner/progress-spinner.html Outdated
Comment threadsrc/material-experimental/mdc-progress-spinner/progress-spinner.scss Outdated

jelbourn reviewed Jul 24, 2020
View reviewed changes

annieyw added 12 commits July 27, 2020 13:38

add files for MDC-based MatProgressSpinner
e94b384

add demo of mdc-based MatProgressSpinner at localhost:4200/mdc-progre…
2b1eda6
…ss-spinner

copy MDC DOM and add MDC styles
d20bb21

set up MDC foundation for MDC-based MatProgressSpinner
d132050

(wip) add adapter and fill in API
df558f4

copy over existing demo to MDC-based demo
db782b1

serverside rendering, refactor
cd8c835

add tests (adapter class wip)
e821045

remove separate class for MatSpinner
122174f

add e2e tests
b648bfb

add harness
dfbda93

add user documantation README
eda65bb

annieyw force-pushed the mdc-progress-spinner branch from 5f6798b to d9592f5Compare July 27, 2020 21:47

add codeowner, theme dep
de98adf

annieyw force-pushed the mdc-progress-spinner branch from d9592f5 to de98adfCompare July 27, 2020 21:50

annieyw added 3 commits July 27, 2020 15:43

address CI failures
b979d77

export MatSpinner as const to avoid build error
f3b7bf2

fix missing e2e import
6e2bd83

mmalerba approved these changes Jul 28, 2020
View reviewed changes

Comment threadsrc/material-experimental/mdc-progress-spinner/progress-spinner.ts Outdated
Comment threadsrc/material-experimental/mdc-progress-spinner/progress-spinner.ts
Comment threadsrc/material-experimental/mdc-progress-spinner/progress-spinner.ts

mmalerba added lgtm target: patch This PR is targeted for the next patch release labels Jul 28, 2020

fix nits
664e363

annieyw added the action: merge The PR is ready for merge by the caretaker label Jul 28, 2020

jelbourn approved these changes Jul 28, 2020
View reviewed changes

jelbourn reviewed Jul 29, 2020
View reviewed changes

Comment threadsrc/material-experimental/mdc-theming/_all-theme.scss Outdated

jelbourn removed the merge safe label Jul 29, 2020

remove changes to _all-themes to keep PR merge-safe (add back in foll…
1329707
…owup)

annieyw added the merge safe label Jul 29, 2020

mmalerba removed the lgtm label Jul 31, 2020

jelbourn merged commit 294b8ee into angular:masterJul 31, 2020

annieyw deleted the mdc-progress-spinner branch August 3, 2020 16:51

annieyw mentioned this pull request Aug 3, 2020
fix(progress-spinner) add theme for mdc-progress-spinner #20170
Merged

mmalerba changed the title ~~prototype(progress-spinner): create prototype progress-spinner based on MDC Web~~feat(progress-spinner): create prototype progress-spinner based on MDC WebAug 26, 2020

mmalerba changed the title ~~feat(progress-spinner): create prototype progress-spinner based on MDC Web~~feat(progress-spinner): create progress-spinner based on MDC WebAug 26, 2020

angular-automatic-lock-botBot locked and limited conversation to collaborators Sep 26, 2020

Uh oh!

Conversation

annieyw commented Jul 20, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crisbeto commented Jul 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jelbournJul 23, 2020

Choose a reason for hiding this comment

Uh oh!

annieywJul 24, 2020

Choose a reason for hiding this comment

Uh oh!

jelbournJul 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jelbournJul 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmalerba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jelbourn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

angular-automatic-lock-botBot commented Sep 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants