Skip to content

fix(progress-spinner) add theme for mdc-progress-spinner - #20170

Merged
mmalerba merged 1 commit into
angular:masterfrom
annieyw:add-theme
Sep 5, 2020
Merged

fix(progress-spinner) add theme for mdc-progress-spinner#20170
mmalerba merged 1 commit into
angular:masterfrom
annieyw:add-theme

Conversation

@annieyw

@annieywannieyw commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

previously excluded in #20048 to keep it merge safe

@annieyw
annieyw requested a review from mmalerba as a code ownerAugust 3, 2020 19:36
@googlebotgooglebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 3, 2020
@mmalerba

mmalerba commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

Can you change commit message to fix(progress-spinner) add theme for mdc-progress-spinner

@mmalerbammalerba added the target: patch This PR is targeted for the next patch release label Aug 3, 2020
mmalerba
mmalerba approved these changes Aug 3, 2020
View reviewed changes

@mmalerbammalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieywannieyw changed the title prototype(progres-spinner) add theme for mdc-progress-spinnerfix(progress-spinner) add theme for mdc-progress-spinnerAug 3, 2020
@annieywannieyw added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2020
@andrewseguinandrewseguin added the P2 The issue is important to a large percentage of users, with a workaround label Aug 18, 2020
@mmalerba
mmalerba merged commit faddbaa into angular:masterSep 5, 2020
mmalerba pushed a commit that referenced this pull request Sep 5, 2020
@annieyw@mmalerba
prototype(progres-spinner) add theme for mdc-progress-spinner (#20170)
a307cf1
(cherry picked from commit faddbaa)
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Oct 6, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Oct 6, 2020
@annieyw
annieyw deleted the add-theme branch November 9, 2020 19:42
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mmalerbammalerbammalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: mergeThe PR is ready for merge by the caretakercla: yesPR author has agreed to Google's Contributor License AgreementP2The issue is important to a large percentage of users, with a workaroundtarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@annieyw@mmalerba@googlebot@andrewseguin