Skip to content

fix(material/datepicker): Move aria-live attribute so month can also … - #29137

Merged
amysorto merged 1 commit into
angular:mainfrom
amysorto:missing-month-announcement
Jun 3, 2024
Merged

fix(material/datepicker): Move aria-live attribute so month can also …#29137
amysorto merged 1 commit into
angular:mainfrom
amysorto:missing-month-announcement

Conversation

@amysorto

@amysortoamysorto commented May 29, 2024

Copy link
Copy Markdown
Contributor

…be announced when using previous and next month buttons

@amysorto
fix(material/datepicker): Move aria-live attribute so month can also …
fcbef2d
…be announced when using previous and next month buttons
@amysortoamysorto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release area: material/datepicker action: global presubmit The PR is in need of a google3 global presubmit labels May 29, 2024
@amysorto

amysorto commented May 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Note: This was originally fixed in #24398, but after adding a separate label element in #24958 the month wasn't announced anymore

@amysorto
amysorto marked this pull request as ready for review May 30, 2024 15:27
@amysortoamysorto added action: merge The PR is ready for merge by the caretaker and removed action: global presubmit The PR is in need of a google3 global presubmit labels Jun 3, 2024
@amysorto
amysorto merged commit b9fedfe into angular:mainJun 3, 2024
amysorto added a commit that referenced this pull request Jun 3, 2024
@amysorto
fix(material/datepicker): Move aria-live attribute so month can also …
51488a2
…be announced when using previous and next month buttons (#29137)
(cherry picked from commit b9fedfe)
@ambrose40ambrose40 mentioned this pull request Jun 27, 2024
Open
@AddinAddin mentioned this pull request Jul 1, 2024
Closed
@angular-automatic-lock-bot

angular-automatic-lock-botBot commented Jul 4, 2024

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-botangular-automatic-lock-botBot locked and limited conversation to collaborators Jul 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbetocrisbetocrisbeto approved these changes

Assignees

No one assigned

Labels

AccessibilityThis issue is related to accessibility (a11y)action: mergeThe PR is ready for merge by the caretakerarea: material/datepickertarget: patchThis PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amysorto@crisbeto