Skip to content

Add UnitsNet.NumberExtensions nuget - #742

Merged
angularsen merged 23 commits into
angularsen:masterfrom
wgvdn:master
Feb 6, 2020
Merged

Add UnitsNet.NumberExtensions nuget#742
angularsen merged 23 commits into
angularsen:masterfrom
wgvdn:master

Conversation

@luli0401

@luli0401luli0401 commented Jan 22, 2020•
edited by angularsen
Loading

Copy link
Copy Markdown
Contributor

Fixes#735.

This pull request is based on the discussion of issue #735.
Create new 'UnitsNet.Extensions' project which includes all the NumberToExtensions, and include this NuGet package in the build process.

@luli0401luli0401 mentioned this pull request Jan 22, 2020
Closed
@codecov-io

codecov-io commented Jan 22, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #742 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #742 +/- ##
==========================================
+ Coverage 62.95% 62.96% +<.01% 
==========================================
Files 270 270 Lines 39529 39539 +10 ==========================================
+ Hits 24886 24896 +10 
Misses 14643 14643
Impacted FilesCoverage Δ
UnitsNet/GeneratedCode/UnitAbbreviationsCache.g.cs100% <ø> (ø)⬆️
UnitsNet/GeneratedCode/UnitConverter.g.cs100% <100%> (ø)⬆️
UnitsNet/GeneratedCode/Quantities/Force.g.cs61.36% <100%> (+0.75%)⬆️
...ensions/GeneratedCode/NumberToForceExtensions.g.cs100% <0%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 214d2c9...862a84f. Read the comment docs.

angularsen
angularsen requested changes Jan 28, 2020
View reviewed changes

@angularsenangularsen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's starting to look very good, a few comments.

Comment threadBuild/bump-version-UnitsNet.Extensions-major.bat Outdated
Comment threadUnitsNet.Extensions.Tests/NumberToExtensions/NumberExtensionsTest.cs Outdated
Comment threadUnitsNet.Extensions/GeneratedCode/NumberToExtensions/NumberToAccelerationExtensions.g.cs Outdated
Comment threadUnitsNet.Extensions/UnitsNet.Extensions.csproj Outdated
@angularsen

angularsen commented Jan 31, 2020 via email

Copy link
Copy Markdown
Owner

@luli0401
Merge pull request#5from angularsen/master
66a2706
Get the latest version from uptream
@luli0401
Sync the Extension project version number with the main library, add …
23972ff
…a test project for extension methods, and improve the Extension project decription.
@luli0401
Get latest version
fbef3d5
@luli0401
Update the verion number for NumberExtensions project,
d3c173d
@luli0401
Merge pull request#6from wgvdn/Add_NumberToExtenisons_Back
525953d
Sync the Extension project version number with the main library, add a test project for extension methods, and improve the Extension project description.
@luli0401
Fix the NuGet package name, and add new test project to the build pro…
15e4d8d
…cess.
@luli0401
Merge pull request#7from wgvdn/Add_NumberToExtenisons_Back
214d2c9
Fix the NuGet package name, and add new test project to the build pro…
angularsen
angularsen approved these changes Feb 6, 2020
View reviewed changes

@angularsenangularsen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good!
It's a bit hard to say for sure, there are a ton of changes here, but I've skimmed through it and can't find any obvious problems with it. I think we should just let it roll out and start playing with the new nuget 🎉

Comment threadUnitsNet.NumberExtensions.Tests/GeneratedCode/NumberToAccelerationExtensionsTest.g.cs
Comment threadUnitsNet.NumberExtensions/UnitsNet.NumberExtensions.csproj Outdated
@angularsenangularsen changed the title 'NumberTo' Extensions RestorationAdd UnitsNet.NumberExtensions nugetFeb 6, 2020
@angularsen
angularsen merged commit fc6f06b into angularsen:masterFeb 6, 2020
@angularsen

angularsen commented Feb 6, 2020

Copy link
Copy Markdown
Owner

@luli0401 And it's live! :-)

https://www.nuget.org/packages/UnitsNet.NumberExtensions/4.44.0

I did a quick test referencing the nuget and it works as expected 🎉

@luli0401

luli0401 commented Feb 6, 2020

Copy link
Copy Markdown
ContributorAuthor

@luli0401 And it's live! :-)

https://www.nuget.org/packages/UnitsNet.NumberExtensions/4.44.0

I did a quick test referencing the nuget and it works as expected 🎉

I saw that, excellent!
Thank you for all your help.

@angularsen

angularsen commented Feb 6, 2020

Copy link
Copy Markdown
Owner

And thank you for the great work 😀 It was solid.

@angularsen

angularsen commented Feb 10, 2020

Copy link
Copy Markdown
Owner

Release UnitsNet/4.45.0 · angularsen/UnitsNet

@angularsenangularsen mentioned this pull request May 6, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angularsenangularsenangularsen approved these changes
+1 more reviewer
@jonsudajonsudajonsuda left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restoration of Extension Methods

6 participants

@luli0401@codecov-io@angularsen@jonsuda@ArdentLogician@gojanpaolo