') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Configurable AWS Session Factory by alexchen8 · Pull Request #21778 · apache/airflow · GitHub
Skip to content

Configurable AWS Session Factory - #21778

Merged
potiuk merged 1 commit into
apache:mainfrom
alexchen8:aws-session-factory
Feb 28, 2022
Merged

Configurable AWS Session Factory#21778
potiuk merged 1 commit into
apache:mainfrom
alexchen8:aws-session-factory

Conversation

@alexchen8

@alexchen8alexchen8 commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Configurable AWS SessionFactory for users to have full control of AWS boto3 session instantiation. This will also allow custom federated AWS access.

closes: #21672

@boring-cyborgboring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues labels Feb 24, 2022
@alexchen8
alexchen8force-pushed the aws-session-factory branch 2 times, most recently from 5755c73 to 05ea2f6CompareFebruary 24, 2022 05:13
@potiuk

potiuk commented Feb 27, 2022

Copy link
Copy Markdown
Member

The change is fine but it has zero user-facing documentation. Please explain it in the amazon providers howtos and docstrings. Some examples of usage where it can be used should be added.

@alexchen8alexchen8 changed the title Configurable AWS SessionFactoryConfigurable AWS Session FactoryFeb 28, 2022
@alexchen8

alexchen8 commented Feb 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Added documentation. Not sure if it's in the right format.

@potiuk

potiuk commented Feb 28, 2022

Copy link
Copy Markdown
Member

Added documentation. Not sure if it's in the right format.

This looks super cool!

@potiuk
potiuk merged commit c819b4f into apache:mainFeb 28, 2022
@github-actionsgithub-actionsBot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 28, 2022
@github-actions

github-actionsBot commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@alexchen8
alexchen8 deleted the aws-session-factory branch February 28, 2022 17:23
@potiukpotiuk mentioned this pull request Mar 7, 2022
Closed
84 tasks
@potiukpotiuk mentioned this pull request Mar 15, 2022
Closed
41 tasks
@TaragolisTaragolis mentioned this pull request Aug 31, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@mik-lajmik-lajAwaiting requested review from mik-laj

Assignees

No one assigned

Labels

area:providersokay to mergeIt's ok to merge this PR as it does not require more testsprovider:amazonAWS/Amazon - related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[AWS] Configurable AWS SessionFactory for AwsBaseHook

2 participants

@alexchen8@potiuk