Skip to content

Make aws.session_factory part of Amazon provider configuration documentation - #33960

Merged
vincbeck merged 4 commits into
apache:mainfrom
Taragolis:aws-configuration
Sep 1, 2023
Merged

Make aws.session_factory part of Amazon provider configuration documentation#33960
vincbeck merged 4 commits into
apache:mainfrom
Taragolis:aws-configuration

Conversation

@Taragolis

Copy link
Copy Markdown
Contributor

Add [aws] session_factory part of AWS Documentation. This configuration option added in #21778 and 3.1.1 version of provider.

This PR doesn't add it in global configuration reference, better add after documentation to Amazon Provider updated, so we do not have missing link in documentation


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Comment threadairflow/providers/amazon/provider.yaml Outdated
@TaragolisTaragolis changed the title Make aws.session_factory part of Amazon provider configurationMake aws.session_factory part of Amazon provider configuration documentationAug 31, 2023

@vincbeckvincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me but since I am not an english native speaker I am not the best person to review documentation related changes. @o-nikolas if you have a bit of time maybe?

@hussein-awalahussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment threadairflow/providers/amazon/provider.yaml Outdated
Comment threadairflow/providers/amazon/provider.yaml Outdated
Comment threadairflow/providers/amazon/provider.yaml Outdated
@Taragolis

Taragolis commented Sep 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Converted to draft, for prevent merge it before #34011 Done

@Taragolis
Taragolis marked this pull request as ready for review September 1, 2023 15:03
@vincbeck
vincbeck merged commit 6eaa69e into apache:mainSep 1, 2023
@Taragolis
Taragolis deleted the aws-configuration branch September 1, 2023 17:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Taragolis@Lee-W@hussein-awala@o-nikolas@vincbeck