Remove Run task action from UI

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.

[bbovenzi]

Airflow.run is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success).

Note: Since it is broken, I feel like this counts as a bug fix for 2.5.2. But if removing a UI element is too drastic I'm fine to move this to 2.6.0 instead

Before:

After:

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kaxil]

Trying to think if we should remove it from

airflow/airflow/www/views.py

Lines 1848 to 1904 in 8449180

	defrun(self, session=None):
	"""Runs Task Instance."""
	dag_id=request.form.get("dag_id")
	task_id=request.form.get("task_id")
	dag_run_id=request.form.get("dag_run_id")
	map_index=request.args.get("map_index", -1, type=int)
	origin=get_safe_url(request.form.get("origin"))
	dag=get_airflow_app().dag_bag.get_dag(dag_id)
	ifnotdag:
	returnredirect_or_json(origin, "DAG not found", "error", 404)
	task=dag.get_task(task_id)
	ignore_all_deps=request.form.get("ignore_all_deps") =="true"
	ignore_task_deps=request.form.get("ignore_task_deps") =="true"
	ignore_ti_state=request.form.get("ignore_ti_state") =="true"
	executor=ExecutorLoader.get_default_executor()
	ifnotexecutor.supports_ad_hoc_ti_run:
	msg=f"{executor.__class__.__name__} does not support ad hoc task runs"
	returnredirect_or_json(origin, msg, "error", 400)
	dag_run=dag.get_dagrun(run_id=dag_run_id, session=session)
	ifnotdag_run:
	returnredirect_or_json(origin, "DAG run not found", "error", 404)
	ti=dag_run.get_task_instance(task_id=task.task_id, map_index=map_index, session=session)
	ifnotti:
	msg="Could not queue task instance for execution, task instance is missing"
	returnredirect_or_json(origin, msg, "error", 400)
	ti.refresh_from_task(task)
	# Make sure the task instance can be run
	dep_context=DepContext(
	deps=RUNNING_DEPS,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	failed_deps=list(ti.get_failed_dep_statuses(dep_context=dep_context))
	iffailed_deps:
	failed_deps_str=", ".join(f"{dep.dep_name}: {dep.reason}"fordepinfailed_deps)
	msg=f"Could not queue task instance for execution, dependencies not met: {failed_deps_str}"
	returnredirect_or_json(origin, msg, "error", 400)
	executor.job_id=None
	executor.start()
	executor.queue_task_instance(
	ti,
	ignore_all_deps=ignore_all_deps,
	ignore_task_deps=ignore_task_deps,
	ignore_ti_state=ignore_ti_state,
	)
	executor.heartbeat()
	ti.queued_dttm=timezone.utcnow()
	session.merge(ti)
	msg=f"Sent {ti} to the message queue, it should start any moment now."
	returnredirect_or_json(origin, msg)

🤔

[dimberman]

@kaxil what would be the benefit of keeping it?

[eladkal]

the run command is also available from CLI. I'm missing the part why it makes sense to use it in CLI but not from the UI? the end result is the same doesn't it?

[jedcunningham]

The CLI will be a little trickier, but yes, the non --local or --raw path which spins up an executor should probably also be axed.

[jedcunningham]

And --local certainly makes sense - it's how KubernetesExecutor works. I'm not familiar enough with --raw to speak to that one though.

[uranusjr]

IIRC --raw is needed for (some?) other executors to run the task.

[jedcunningham]

Yeah, when troubleshooting something else today, I happened to find that --local ends up using --raw as well 👍. Either way, I think we should address the UI and CLI separately.