Skip to content

[WIP] Migrate core EmailOperator to SMTP provider - #30531

Draft
hussein-awala wants to merge 5 commits into
apache:mainfrom
hussein-awala:migrate_core_email_operator
Draft

[WIP] Migrate core EmailOperator to SMTP provider#30531
hussein-awala wants to merge 5 commits into
apache:mainfrom
hussein-awala:migrate_core_email_operator

Conversation

@hussein-awala

@hussein-awalahussein-awala commented Apr 7, 2023

Copy link
Copy Markdown
Member

closes: #30530

In this PR, we migrate core EmailOperator to SMTP provider, and we deprecate the core one.

@hussein-awala
hussein-awalaforce-pushed the migrate_core_email_operator branch from 895f99d to 2f93d11CompareApril 10, 2023 22:25
@github-actions

github-actionsBot commented May 26, 2023

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actionsgithub-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 26, 2023
@hussein-awalahussein-awala removed the stale Stale PRs per the .github/workflows/stale.yml policy file label May 26, 2023
ITJamie
ITJamie reviewed Jun 23, 2023
View reviewed changes
Comment threadairflow/utils/email.py

# for credentials, we use the connection if it exists, otherwise we use the config
if connection.login is None or connection.password is None:
warnings.warn(

@ITJamieITJamieJun 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning assumes incorrectly that it has to fallback to cfg settings to find a username or password for smtp. Not all smtp servers require authentication to send mail.

It can not be assumed that if a connection has no username or password that the connection config is wrong and thus falling back to legacy config

@potiukpotiuk mentioned this pull request Aug 3, 2023
Merged
@github-actions

github-actionsBot commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actionsgithub-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Aug 8, 2023
@hussein-awalahussein-awala added pinned Protect from Stalebot auto closing and removed stale Stale PRs per the .github/workflows/stale.yml policy file labels Aug 8, 2023
@potiukpotiuk mentioned this pull request Aug 10, 2023
Closed
@eladkaleladkal added provider:smtp pinned Protect from Stalebot auto closing area:providers and removed pinned Protect from Stalebot auto closing kind:documentation labels Aug 27, 2023
@eladkaleladkal mentioned this pull request Feb 26, 2024
Closed
3 tasks
@eladkal

eladkal commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

@hussein-awala i think now that main branch is Airflow 3 this PR should be easier

@eladkaleladkal mentioned this pull request Dec 24, 2024
Closed
@eladkaleladkal mentioned this pull request Jan 16, 2025
Closed
@eladkal

eladkal commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

@hussein-awala will you have time to complete this one?

@hussein-awala

hussein-awala commented Jan 25, 2025

Copy link
Copy Markdown
MemberAuthor

@hussein-awala will you have time to complete this one?

I will try to complete it by tomorrow.

@hussein-awala

hussein-awala commented Jan 25, 2025

Copy link
Copy Markdown
MemberAuthor

@eladkal I think there is no need to migrate it, we can delete the resources we want to deprecate and clean the code. I created this draft: #46041.

For version 2.11, and since the provider operator and SMTP Notifer have been introduced for quite some time, we don't need to create a complicated backport, IMHO it will be enough to inform/warn users about the upcoming deprecation. WDYT?

@eladkal

eladkal commented Jan 25, 2025

Copy link
Copy Markdown
Contributor

I agree. The goal is to remove email integration from core completely

eladkal
eladkal reviewed Feb 11, 2025
View reviewed changes
Comment threadairflow/operators/email.py

@eladkaleladkalFeb 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep it?
We migrated almost all core operators to standard provider.
Should we just remove this file?

@eladkaleladkal mentioned this pull request Jun 13, 2025
Merged
@eladkaleladkal mentioned this pull request Jul 20, 2025
Merged
@aaron-y-chen

aaron-y-chen commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

Hi @hussein-awala, do you think we should continue with this PR, perhaps by reopening your draft #46041?

@eladkaleladkal mentioned this pull request Mar 29, 2026
Closed
1 task
@wilmerdooleywilmerdooley mentioned this pull request Jun 3, 2026
Draft
1 task
@eladkaleladkal mentioned this pull request Jun 14, 2026
Closed
@eladkaleladkal mentioned this pull request Jul 14, 2026
Merged
1 task
@eladkaleladkal mentioned this pull request Aug 12, 2026
Open
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladkaleladkaleladkal left review comments
+1 more reviewer
@ITJamieITJamieITJamie left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area:providerspinnedProtect from Stalebot auto closingprovider:smtp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate core EmailOperator to SMTP provider

4 participants

@hussein-awala@eladkal@aaron-y-chen@ITJamie