Uh oh!
There was an error while loading. Please reload this page.
Add optional from_email parameter to EmailOperator - #33288
Add optional from_email parameter to EmailOperator#33288shakeelansari63 wants to merge 8 commits into
Conversation
shakeelansari63
commented
Aug 10, 2023
Related to #33287 |
potiuk
commented
Aug 10, 2023
also related to #30531 cc: @hussein-awala |
vijayasarathib
commented
Aug 10, 2023
Have you considered adding test cases to verify the new behavior? |
You are right. Let me update the test to check whether this field is passed to backend. |
shakeelansari63
commented
Aug 10, 2023
I have updated the test for verifying new from_email parameter. |
shakeelansari63
commented
Aug 10, 2023
@potiuk , would you be able to approve the test workflow for latest commit. Need to re-run the tests as I have email test. |
eladkal
left a comment
There was a problem hiding this comment.
I'm setting PR to request changes to avoid merge.
Needs to wait for @hussein-awala review as he is working on refactoring this operator into the smtp provider.
(This is technical step not to worry)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Franz1241
commented
Sep 25, 2023
Will this get merged to main? |
shakeelansari63
commented
Sep 25, 2023
@hussein-awala , Can you please review this and check if this PR can be merged? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
shakeelansari63
commented
May 3, 2024
@hussein-awala , Did you get a chance to review this PR? |
shakeelansari63
commented
Jun 16, 2024
Look like the Airflow team isn't interested in this feature. Hence closing this PR. |
closes: #33287
Add optional from_email parameter to EmailOperator which allows users to provide sender emails in Dags.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.