Uh oh!
There was an error while loading. Please reload this page.
Fix stacklevel in warnings.warn into the providers - #36831
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
9f3cb1f to
43915a9Compare
potiuk
left a comment
There was a problem hiding this comment.
Nice. I was wondering if there is a way to somehow automate it - or maybe just flag and require to make a deliberate decision when you reais exception in the provider?
Taragolis
commented
Jan 17, 2024
Missing stacklevel=1 in most cases it useless level, because it point to exact place where it raised rather than where it called. We could add B028 to ruff config as soon as we resolve this PR, #36834 and make changes in core |
During check warnings which generated in our CI I've found that time to time we use
stacklevel=1or even do not define it at all. This make it harder to find where actual call is happen.There is rule
B028exists into therufffor validate missingstacklevelinto the code, however nothing it could do with explicitstacklevel=1There is additional changes exists in warnings, which I point into the separate discussions
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.