Uh oh!
There was an error while loading. Please reload this page.
Enable none default ftp port - #39048
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
kerlion
commented
Apr 16, 2024
Is this the failed check? But it is ftp without TLS or ssl, we do have this scenario. |
Uh oh!
There was an error while loading. Please reload this page.
dirrao
left a comment
There was a problem hiding this comment.
can you add the test case for the current scenario?
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
commented
Apr 19, 2024
This probably should have a test? |
kerlion
commented
Apr 22, 2024
Hi, is this ready for merging, anything else need I to do? |
potiuk
commented
Apr 22, 2024
Have you seen this @kerlion ?
|
eladkal
left a comment
There was a problem hiding this comment.
Can you please add unit test to cover this change?
kerlion
commented
Apr 28, 2024
Sorry, I do know know how to add unit test, but I tested it in my PROD env. |
eladkal
commented
May 27, 2024
Suppressed by #39465 |
When I use ftp hook in my airflow env, it will wait till timeout when I use a none-standard ftp port. I fixed it by modify the source code. It has run for 2+ months without issue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.