Skip to content

Allow FTPHook to change port number - #39465

Merged
potiuk merged 9 commits into
apache:mainfrom
VelmiraPetkova:fix-issue-39308
May 27, 2024
Merged

Allow FTPHook to change port number#39465
potiuk merged 9 commits into
apache:mainfrom
VelmiraPetkova:fix-issue-39308

Conversation

@VelmiraPetkova

@VelmiraPetkovaVelmiraPetkova commented May 7, 2024

Copy link
Copy Markdown
Contributor

Allow FTPHook to use a custom FTP port number

closes: #39308

@boring-cyborg

boring-cyborgBot commented May 7, 2024

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

dirrao
dirrao requested changes May 8, 2024
View reviewed changes

@dirraodirrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR.
Can you add the test case for custom port?

@VelmiraPetkova

VelmiraPetkova commented May 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Yes, I'll do the test case over the weekend.

vincbeck
vincbeck reviewed May 13, 2024
View reviewed changes
Comment threadairflow/providers/ftp/hooks/ftp.py
@VelmiraPetkova

VelmiraPetkova commented May 14, 2024

Copy link
Copy Markdown
ContributorAuthor

I did some tests and fixed a tiny bug, when no port is supplied.

amoghrajesh
amoghrajesh reviewed May 16, 2024
View reviewed changes
Comment threadairflow/providers/ftp/hooks/ftp.py
amoghrajesh
amoghrajesh approved these changes May 17, 2024
View reviewed changes

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VelmiraPetkova
LGTM +1

@eladkal

eladkal commented May 26, 2024

Copy link
Copy Markdown
Contributor

@VelmiraPetkova can you please fix static checks?

@VelmiraPetkova

VelmiraPetkova commented May 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Sorry for the delay. I updated the PR. Could you please take a look? Thank you!

amoghrajesh
amoghrajesh approved these changes May 27, 2024
View reviewed changes

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @VelmiraPetkova!

@dirrao wdyt?

eladkal
eladkal reviewed May 27, 2024
View reviewed changes
Comment threadairflow/providers/ftp/hooks/ftp.py
@potiuk

potiuk commented May 27, 2024

Copy link
Copy Markdown
Member

The failing integration test case is a flake - mssql does not have enough time to start. This has been fixed in #39866

@potiuk
potiuk merged commit 9f0b025 into apache:mainMay 27, 2024
@boring-cyborg

boring-cyborgBot commented May 27, 2024

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkaleladkal mentioned this pull request May 27, 2024
Closed
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
@VelmiraPetkova@eladkal@fdemiane
Allow FTPHook to change port number (apache#39465)
f58a8d8
* Allow FTPHook to change port
* Add integration tests and fix a bug
* Styling fix
* Add logging of the FTP host and port
* Update logging and test styling
* styling fix
* formatting change
* Update airflow/providers/ftp/hooks/ftp.py
* fix log statement formatting
---------
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
@negsteknegstek mentioned this pull request Jun 14, 2024
Closed
2 tasks
@eladkaleladkal mentioned this pull request Jun 22, 2024
Closed
96 tasks
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@VelmiraPetkova@eladkal@romsharon98
Allow FTPHook to change port number (apache#39465)
0d62742
* Allow FTPHook to change port
* Add integration tests and fix a bug
* Styling fix
* Add logging of the FTP host and port
* Update logging and test styling
* styling fix
* formatting change
* Update airflow/providers/ftp/hooks/ftp.py
* fix log statement formatting
---------
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladkaleladkaleladkal left review comments
@potiukpotiukpotiuk approved these changes
@amoghrajeshamoghrajeshamoghrajesh approved these changes
@vincbeckvincbeckvincbeck approved these changes
@dirraodirraoAwaiting requested review from dirrao

Assignees

No one assigned

Labels

area:providersprovider:ftp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FTPHook doesn't not allow to change port

6 participants

@VelmiraPetkova@eladkal@potiuk@amoghrajesh@dirrao@vincbeck