Skip to content

Remove RAW HTML support from Trigger Form UI - #40029

Merged
jscheffl merged 4 commits into
apache:mainfrom
jscheffl:feature/remove-trigger-form-support-for-raw-html
Aug 21, 2024
Merged

Remove RAW HTML support from Trigger Form UI#40029
jscheffl merged 4 commits into
apache:mainfrom
jscheffl:feature/remove-trigger-form-support-for-raw-html

Conversation

@jscheffl

@jscheffljscheffl commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

As follow-up of PR #35460 I propose to remove RAW HTML form support in Airflow 2.10. It was deprecated in 2.8 as of raised security concerns allowing to inject JavaScript into client browser.

You could treat it as "breaking change", following the announced deprecation in 2.8 I would judge it as "anti feature" and therefore can be considered as cleanup / feature release.

@boring-cyborgboring-cyborgBot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:documentation labels Jun 3, 2024
@jscheffljscheffl added this to the Airflow 2.10.0 milestone Jun 3, 2024
@jedcunningham

Copy link
Copy Markdown
Member

I'm generally against this given how we currently handle deprecations - this is a breaking change for those users, and those using it today have already accepted the security risks.

Unless we want to define a policy where we remove deprecated features generally after x time/releases/something, I don't think it's appropriate to remove it from Airflow 2. We have a ton of deprecated features (cough subdags cough) that would meet this "anti feature" bar that we can't remove.

@potiuk

Copy link
Copy Markdown
Member

I'm generally against this given how we currently handle deprecations - this is a breaking change for those users, and those using it today have already accepted the security risks.

Unless we want to define a policy where we remove deprecated features generally after x time/releases/something, I don't think it's appropriate to remove it from Airflow 2. We have a ton of deprecated features (cough subdags cough) that would meet this "anti feature" bar that we can't remove.

Agree. We should remove it in Airlfow 3.

@jscheffl

Copy link
Copy Markdown
ContributorAuthor

Okay, then I'll try to keep this PR in memory until we have an AF3 branch to clean-up

@jscheffljscheffl closed this Jun 4, 2024
@jscheffl

Copy link
Copy Markdown
ContributorAuthor

As plans for Airflow 3 are around the corner... re-open to have a first cleanup mergeable after new development branch is ready :-D

@jscheffljscheffl reopened this Jul 17, 2024
@kaxilkaxil added the airflow3.0:candidate Potential candidates for Airflow 3.0 label Jul 31, 2024
@jscheffl
jschefflforce-pushed the feature/remove-trigger-form-support-for-raw-html branch from ac9b685 to ad28ac0CompareAugust 20, 2024 12:17
@jscheffljscheffl added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes and removed airflow3.0:candidate Potential candidates for Airflow 3.0 labels Aug 20, 2024
@jscheffl
jschefflforce-pushed the feature/remove-trigger-form-support-for-raw-html branch from d02ca32 to f45006eCompareAugust 20, 2024 13:29
@jscheffl
jschefflforce-pushed the feature/remove-trigger-form-support-for-raw-html branch from f45006e to fe207d5CompareAugust 20, 2024 21:53
@jscheffl
jscheffl merged commit 23e9716 into apache:mainAug 21, 2024
@Lee-WLee-W mentioned this pull request Nov 18, 2024
2 tasks
@jscheffl
jscheffl deleted the feature/remove-trigger-form-support-for-raw-html branch October 5, 2025 07:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

airflow3.0:breakingCandidates for Airflow 3.0 that contain breaking changesarea:UIRelated to UI/UX. For Frontend Developers.area:webserverWebserver related Issueskind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jscheffl@jedcunningham@potiuk@kaxil