Update existing significant newsfragments with the later introduced template format by Lee-W · Pull Request #45678 · apache/airflow

Lee-W · 2025-01-15T11:25:43Z

Why

Since #44378, we have implemented a newsfragments template to track the breaking changes we have made. However, this template was introduced after many of our earlier breaking changes, which means that most of the existing news fragments do not conform to this format. By updating the existing entries to match the template, we will be able to create a script that summarizes the breaking changes made in Airflow 3.0.

What

Update existing significant newsfragments with the type of changes and migration rules we added in #41641

Closes: #45673

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

vincbeck

I reviewed all my newsfragment and they look good. Here is the list:

newsfragments/41434.significant.rst
newsfragments/42042.significant.rst
newsfragments/42280.significant.rst
newsfragments/43096.significant.rst
newsfragments/aip-79.significant.rst

I added a comment to add a new type of change. Let me know what you think.

kaxil

Heros work Wei 🫡

kaxil · 2025-01-15T18:02:33Z

#protm

gopidesupavan

Thanks wei, looks awesome , i have added my comment.

potiuk · 2025-01-16T18:27:28Z

The list moved to the top.

potiuk · 2025-01-16T18:29:14Z

A bit of "magic" scripting and I generated list of PRs + authors in a checklist form - this should make it easier to know who should review what and keep track of it.

gopidesupavan · 2025-01-16T18:29:51Z

A bit of "magic" scripting and I generated list of PRs + authors in a checklist form - this should make it easier to know who should review what and keep track of it.

Super 😍

potiuk · 2025-01-16T18:31:46Z

reviewed mine and marked them in the list

potiuk · 2025-01-16T18:33:58Z

@Lee-W -> If you want - you can move the list up from the comment I made to the description of the PR - to keep it at the top.

Lee-W · 2025-01-17T01:37:07Z

A bit of "magic" scripting and I generated list of PRs + authors in a checklist form - this should make it easier to know who should review what and keep track of it.

yep, it's super helpful! just updated it

vatsrahul1001 · 2025-01-17T03:59:11Z

Thanks @Lee-W. I have reviewed my changes newsfragments/44533.significant.rst. LGTM!

Lee-W · 2025-01-17T04:45:53Z

I'll keep it open for around 1 week so that everyone can take a look

shahar1 · 2025-01-17T06:46:52Z

I'd be happy for an explanation about what each "type of change" covers. In my case, I removed a a deprecated TriggerRule and it was considered only as a "DAG change". Should it be marked also as a "Code interface change" and/or "Behaviour changes" (due to the interface breaking)?

…template format

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

Lee-W · 2025-01-24T03:19:50Z

I think we already have enough checks for this one. Merge it. Thanks for everyone's help!

…emplate format (apache#45678) * docs(newsfragments): add empty entities to significant newsfragments * docs(newsfragments): update existing siginificant newsfragments with template format * docs(newsfragments): fix typo in 41391, 41533 * docs(newsfragments): add type "Code interface change" * docs(newsfragments): aip-79: make it dependency change * docs(newsfragmenst): update 42042 change type Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> * docs(newsfragmenst): update 40029 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41758 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 43612 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41808 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragmenst): update 41774 change type Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * docs(newsfragments): add description to each of the change type * docs(newsfragments): fix plural typo * docs(newsfragments): replace DAG as Dag * style(newsfragments): add type of change to significant * docs(newsfragments): fix type of changes typo * docs(newsfragments): unify ruff rules format --------- Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

Lee-W changed the title ~~Update existing significant newsfragments with the later introduced template format #45673~~Update existing significant newsfragments with the later introduced template formatJan 15, 2025

vincbeck reviewed Jan 15, 2025
View reviewed changes

Comment threadnewsfragments/aip-79.significant.rst

kaxil reviewed Jan 15, 2025
View reviewed changes

Comment threadnewsfragments/41391.significant.rst Outdated

kaxil approved these changes Jan 15, 2025
View reviewed changes

kaxil reviewed Jan 15, 2025
View reviewed changes

gopidesupavan reviewed Jan 15, 2025
View reviewed changes

Comment threadnewsfragments/41533.significant.rst Outdated

gopidesupavan approved these changes Jan 15, 2025
View reviewed changes

Lee-W force-pushed the update-newsfragments branch from b8e1806 to 2204b7bCompare January 16, 2025 08:07

vincbeck reviewed Jan 16, 2025
View reviewed changes

Comment threadnewsfragments/42042.significant.rst Outdated

vincbeck approved these changes Jan 16, 2025
View reviewed changes