Skip to content

Remove deprecated SubDags - #41390

Merged
kaxil merged 4 commits into
apache:mainfrom
astronomer:remove-subdags
Aug 13, 2024
Merged

Remove deprecated SubDags#41390
kaxil merged 4 commits into
apache:mainfrom
astronomer:remove-subdags

Conversation

@kaxil

@kaxilkaxil commented Aug 11, 2024

Copy link
Copy Markdown
Member

This PR removes SubDags in favor of TaskGroups fro Airflow 3.0

Subdags have been removed from the following locations:

  • CLI
  • API
  • SubDagOperator

This removal marks the end of Subdag support across all interfaces. Users should transition to using TaskGroups as a more efficient and maintainable alternative.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxilkaxil added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 11, 2024
@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:CLI area:core-operators area:db-migrations PRs with DB migration area:providers area:Scheduler including HA (high availability) scheduler area:serialization provider:celery provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:fab provider:google Google (including GCP) related issues labels Aug 11, 2024
@kaxilkaxil added this to the Airflow 3.0.0 milestone Aug 11, 2024
@kaxil
kaxilforce-pushed the remove-subdags branch 2 times, most recently from 64046c6 to 13118d0CompareAugust 11, 2024 23:48
kaxil
kaxil commented Aug 11, 2024
View reviewed changes
Comment threadairflow/providers/google/cloud/hooks/dataplex.py Outdated
kaxil
kaxil commented Aug 11, 2024
View reviewed changes
Comment threadairflow/providers/fab/auth_manager/security_manager/override.py Outdated
@kaxil
kaxilforce-pushed the remove-subdags branch 2 times, most recently from e535d08 to 903b20cCompareAugust 12, 2024 00:03
@jscheffl

jscheffl commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Oh, in numer of LoC removed as PR this is a high chance to get PR of the month :-D

jedcunningham
jedcunningham reviewed Aug 13, 2024
View reviewed changes
Comment threadairflow/migrations/versions/0003_3_0_0_remove_is_subdag.py
@kaxil
kaxil merged commit 6570c6d into apache:mainAug 13, 2024
@kaxil
kaxil deleted the remove-subdags branch August 13, 2024 20:34
potiuk
potiuk reviewed Aug 13, 2024
View reviewed changes

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much complexity removed ... Good job.

@potiuk

potiuk commented Aug 13, 2024•
edited
Loading

Copy link
Copy Markdown
Member

BTW. One more comment #21867 -> I believe retry for failed task group is the only serious missing feature for Task Groups comparing to SubDags.

Retry for Task Groups: #21867

We should likely consider implementing it.

@kaxil

kaxil commented Aug 13, 2024

Copy link
Copy Markdown
MemberAuthor

BTW. One more comment #21867 -> I believe retry for failed task group is the only serious missing feature for Task Groups comparing to SubDags.

Retry for Task Groups: #21867

We should likely consider implementing it.

Yup, added a label to that issue to track it

eladkal
eladkal reviewed Aug 18, 2024
View reviewed changes
Comment threadairflow/providers/cncf/kubernetes/operators/pod.py
Artuz37 pushed a commit to Artuz37/airflow that referenced this pull request Aug 19, 2024
@kaxil@bbovenzi@Artuz37
Remove deprecated SubDags (apache#41390)
eee6c1a
This PR removes SubDags in favor of TaskGroups fro Airflow 3.0
Subdags have been removed from the following locations:
- CLI
- API
- ``SubDagOperator``
This removal marks the end of Subdag support across all interfaces. Users
should transition to using TaskGroups as a more efficient and maintainable
alternative.
---------
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
@eladkaleladkal mentioned this pull request Aug 19, 2024
Closed
43 tasks
@joaopamaraljoaopamaral mentioned this pull request Aug 19, 2024
Merged
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
@kaxil@bbovenzi@romsharon98
Remove deprecated SubDags (apache#41390)
401712f
This PR removes SubDags in favor of TaskGroups fro Airflow 3.0
Subdags have been removed from the following locations:
- CLI
- API
- ``SubDagOperator``
This removal marks the end of Subdag support across all interfaces. Users
should transition to using TaskGroups as a more efficient and maintainable
alternative.
---------
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
kaxil added a commit to astronomer/airflow that referenced this pull request Sep 2, 2024
@kaxil
Add TODOs in providers code for Subdag code removal
d20f098
Follow-up of apache#41390 (comment)
@kaxilkaxil mentioned this pull request Sep 2, 2024
Merged
@omkar-fossomkar-foss mentioned this pull request Oct 9, 2024
Merged
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 28, 2024
@kaxil
Remove subdag from DAG Serialization schema
5213c2d
Was missed in apache#41390
@kaxilkaxil mentioned this pull request Oct 28, 2024
Merged
kaxil added a commit that referenced this pull request Oct 28, 2024
@kaxil
Remove subdag from DAG Serialization schema (#43444)
7e363c4
Was missed in #41390
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@kaxil@ellisms
Remove subdag from DAG Serialization schema (apache#43444)
3022768
Was missed in apache#41390
@Lee-WLee-W mentioned this pull request Nov 18, 2024
Closed
2 tasks
@Lee-WLee-W mentioned this pull request Dec 2, 2024
Closed
@potiukpotiuk mentioned this pull request Jan 16, 2025
Merged
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 27, 2025
@kaxil
Remove subdag from DAG Serialization schema (#43444)
53ff32b
Was missed in apache/airflow#41390
GitOrigin-RevId: 7e363c4c695fcff422e41dfa54f40577095f1b97
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 22, 2025
@kaxil
Remove subdag from DAG Serialization schema (#43444)
6fb61c5
Was missed in apache/airflow#41390
GitOrigin-RevId: 7e363c4c695fcff422e41dfa54f40577095f1b97
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 20, 2025
@kaxil
Remove subdag from DAG Serialization schema (#43444)
5f57f5d
Was missed in apache/airflow#41390
GitOrigin-RevId: 7e363c4c695fcff422e41dfa54f40577095f1b97
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 26, 2026
@kaxil
Remove subdag from DAG Serialization schema (#43444)
6578bd4
Was missed in apache/airflow#41390
GitOrigin-RevId: 7e363c4c695fcff422e41dfa54f40577095f1b97
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 27, 2026
@kaxil
Remove subdag from DAG Serialization schema (#43444)
63f18c7
Was missed in apache/airflow#41390
GitOrigin-RevId: 7e363c4c695fcff422e41dfa54f40577095f1b97
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 28, 2026
@kaxil
Remove subdag from DAG Serialization schema (#43444)
8d21ddc
Was missed in apache/airflow#41390
GitOrigin-RevId: 7e363c4c695fcff422e41dfa54f40577095f1b97
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk left review comments
@ephraimbuddyephraimbuddyephraimbuddy left review comments
@eladkaleladkaleladkal left review comments
@jedcunninghamjedcunninghamjedcunningham approved these changes
@phanikumvphanikumvphanikumv left review comments
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@ashbashbAwaiting requested review from ashb
@bbovenzibbovenziAwaiting requested review from bbovenzi
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrun
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@XD-DENGXD-DENGAwaiting requested review from XD-DENG
@uranusjruranusjrAwaiting requested review from uranusjr

Assignees

No one assigned

Labels

airflow3.0:breakingCandidates for Airflow 3.0 that contain breaking changesarea:APIAirflow's REST/HTTP APIarea:CLIarea:db-migrationsPRs with DB migrationarea:providersarea:Schedulerincluding HA (high availability) schedulerarea:serializationprovider:celeryprovider:cncf-kubernetesKubernetes (k8s) provider related issuesprovider:fabprovider:googleGoogle (including GCP) related issues

Projects

None yet

Milestone

Airflow 3.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@kaxil@eladkal@jscheffl@potiuk@uranusjr@ephraimbuddy@jedcunningham@phanikumv@bbovenzi