log handler deprecated filename_template argument removal

[dirrao]

Passing filename_template to a log handler is deprecated and has no effect. So, removing deprecated filename_template argument in log handler.

[eladkal]

This PR involves both core and provider changes.
Please clarify what it means for new versions of providers (that will include this PR) but installed with Airflow 2.
Something is odd here.

The parameter in question is public API which is why we deprecate it first. Now main is Airflow 3 so we can remove it but providers must still be compatible with Airflow 2... so how can we remove it from providers safely now?

[dirrao]

This PR involves both core and provider changes. Please clarify what it means for new versions of providers (that will include this PR) but installed with Airflow 2. Something is odd here.

Right now, this field is not being used and has no effect. The filename_template is optional argument with default value None.
We can still able to install and use latest providers on airflow 2 without any issue.

The parameter in question is public API which is why we deprecate it first. Now main is Airflow 3 so we can remove it but providers must still be compatible with Airflow 2... so how can we remove it from providers safely now?

As I said in the above statement, the providers can still work with airflow 2.

[potiuk]

@eladkal is right - if someone installs the new provider witn an old configuration in Airlfow 2 with filename_template, it will just fail with "attemptign to iniitalize handlew with "filename_template" argument passed but it's missing" (or smth like that).

[dirrao]

I see the keyword arguments for the all the

@eladkal is right - if someone installs the new provider witn an old configuration in Airlfow 2 with filename_template, it will just fail with "attemptign to iniitalize handlew with "filename_template" argument passed but it's missing" (or smth like that).

Yah. You are right. Most of them are supporting keyword arguments except one/two (like. es handler).

[dirrao]

@eladkal / @potiuk
Let me know if you want me to revert it for providers alone.

[potiuk]

Just reverting will not be enough, but I think if the base Handler will accept extra arguments (and ignores them) we should be home