Skip to content

Metrics basic deprecated validators removed in favor of pattern matching - #41975

Merged
ferruzzi merged 5 commits into
apache:mainfrom
dirrao:basic_validators_removal
Sep 17, 2024
Merged

Metrics basic deprecated validators removed in favor of pattern matching#41975
ferruzzi merged 5 commits into
apache:mainfrom
dirrao:basic_validators_removal

Conversation

@dirrao

@dirraodirrao commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Metrics basic deprecated validators (AllowListValidator and BlockListValidator) removed in favor of pattern matching

@dirraodirrao self-assigned this Sep 3, 2024
@dirraodirrao added area:metrics airflow3.0:candidate Potential candidates for Airflow 3.0 airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Sep 3, 2024
ferruzzi
ferruzzi requested changes Sep 3, 2024
View reviewed changes

@ferruzziferruzzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so happy to see these deprecation PRs actually removing stuff!

Left an easy change request/suggestion, otherwise LGTM.

Those unit tests were somewhat convoluted, nice work sorting through them.

Comment threadairflow/metrics/validators.py Outdated
Comment threadairflow/metrics/validators.py Outdated
Comment threadtests/core/test_stats.py
Comment threadtests/core/test_stats.py Outdated
@dirrao
dirrao requested a review from ferruzziSeptember 4, 2024 05:33
ferruzzi
ferruzzi approved these changes Sep 4, 2024
View reviewed changes
Comment threadtests/core/test_stats.py
Comment threadairflow/metrics/validators.py
@dirrao
dirrao requested a review from eladkalSeptember 5, 2024 06:32
@dirrao

dirrao commented Sep 10, 2024

Copy link
Copy Markdown
ContributorAuthor

@potiuk / @eladkal
I'm awaiting final approval to proceed with the merge. Could you please take a look when you get a chance?

@potiuk

potiuk commented Sep 11, 2024

Copy link
Copy Markdown
Member

Needs to resolve conflict now.

@dirrao

dirrao commented Sep 12, 2024

Copy link
Copy Markdown
ContributorAuthor

Needs to resolve conflict now.

Done.

@dirrao
dirrao requested a review from potiukSeptember 16, 2024 05:46
@dirrao

dirrao commented Sep 17, 2024

Copy link
Copy Markdown
ContributorAuthor

@eladkal
I'm waiting for the final review and merge.

@ferruzzi
ferruzzi merged commit dfbdb3c into apache:mainSep 17, 2024
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@dirrao@joaopamaral
Metrics basic deprecated validators removed in favor of pattern match…
ebb62ca
…ing (apache#41975)
* metrics basic deprecated validators removed
* metrics basic deprecated validators removed
* news fragment added
@Lee-WLee-W mentioned this pull request Nov 18, 2024
Closed
2 tasks
This was referenced Dec 2, 2024
Closed
Closed
@potiukpotiuk mentioned this pull request Jan 16, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferruzziferruzziferruzzi approved these changes
@uranusjruranusjrAwaiting requested review from uranusjr
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk

Assignees

@dirraodirrao

Labels

airflow3.0:breakingCandidates for Airflow 3.0 that contain breaking changesairflow3.0:candidatePotential candidates for Airflow 3.0area:metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dirrao@potiuk@ferruzzi