Skip to content

Standard provider bash operator - #42252

Merged
romsharon98 merged 48 commits into
apache:mainfrom
gopidesupavan:standard-provider-bash-operator
Oct 9, 2024
Merged

Standard provider bash operator#42252
romsharon98 merged 48 commits into
apache:mainfrom
gopidesupavan:standard-provider-bash-operator

Conversation

@gopidesupavan

@gopidesupavangopidesupavan commented Sep 16, 2024

Copy link
Copy Markdown
Member

Moving bash operators/sensors to standard provider

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan
gopidesupavan marked this pull request as draft September 16, 2024 11:10
@gopidesupavan
gopidesupavanforce-pushed the standard-provider-bash-operator branch from 3ae4647 to a870160CompareSeptember 18, 2024 18:30
@gopidesupavan
gopidesupavan marked this pull request as ready for review September 19, 2024 10:34
@gopidesupavan

gopidesupavan commented Sep 19, 2024

Copy link
Copy Markdown
MemberAuthor

moving this bash operator to standard provider, has module path changes in systems test, integration tests.

failures in python client tests, i am thinking due to bashoperator path change, causing dag not loaded.
Checking remaining tests.

jscheffl
jscheffl reviewed Sep 19, 2024
View reviewed changes
Comment thread.pre-commit-config.yaml Outdated
jscheffl
jscheffl reviewed Sep 19, 2024
View reviewed changes
Comment thread.pre-commit-config.yaml Outdated
jscheffl
jscheffl reviewed Sep 19, 2024
View reviewed changes
Comment threadairflow/example_dags/example_bash_operator.py Outdated
@gopidesupavan
gopidesupavanforce-pushed the standard-provider-bash-operator branch from 0ead57d to c5f4c04CompareSeptember 19, 2024 23:08
jedcunningham
jedcunningham reviewed Sep 20, 2024
View reviewed changes
Comment threadairflow/providers/standard/provider.yaml Outdated
@gopidesupavan

gopidesupavan commented Sep 20, 2024

Copy link
Copy Markdown
MemberAuthor

Could you please help on this, kubernetes executor tests are failing with dag not found example_kubernetes_executor and example_bash_operator. one option i tried copying the standard package to k8s build container, but its still failing with same reason.

@gopidesupavangopidesupavan mentioned this pull request Sep 21, 2024
Merged
@gopidesupavan

gopidesupavan commented Sep 21, 2024

Copy link
Copy Markdown
MemberAuthor

Additional prod image tests also failing, as it doesnt have the standard provider. inside latest prod image pull.
image

@gopidesupavan

gopidesupavan commented Sep 21, 2024

Copy link
Copy Markdown
MemberAuthor

Additional prod image tests also failing, as it doesnt have the standard provider. inside latest prod image pull. image

Any suggestions for these tests?

@gopidesupavan

gopidesupavan commented Sep 21, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

After reviewing the logs, it seems the reason the k8s tests are failing is due to the absence of the standard provider package in the image. This is because i guess the standard provider not included in the prod_image_installed_providers.txt file ?

Is it okay to add standard provider in to that file?

@gopidesupavan
gopidesupavanforce-pushed the standard-provider-bash-operator branch from 50525db to 9905f25CompareSeptember 21, 2024 21:39
@gopidesupavan
gopidesupavanforce-pushed the standard-provider-bash-operator branch from 7745a13 to 726518bCompareOctober 8, 2024 20:39
@gopidesupavan

gopidesupavan commented Oct 8, 2024

Copy link
Copy Markdown
MemberAuthor

Oh, nooo, merge conflict - can you fix this? then LGTM!

yeah just resolved 3.8 removals 😄

There is a test failing , but its not related to this. Would you be able to merge please?

@romsharon98
romsharon98 merged commit a5ffbbd into apache:mainOct 9, 2024
@eladkaleladkal mentioned this pull request Oct 10, 2024
Closed
96 tasks
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
@potiuk@kunaljubce
Add standard provider to chicken-egg-providers (apache#42760)
c867760
Standard provider should be added to chicken-egg-providers as it
has not yet been officially released, so we need to add it.
This can only be done via "apache" PR as it is needed in build-images
workflow. This is needed to unblock apache#42252
kunaljubce pushed a commit to kunaljubce/airflow that referenced this pull request Oct 13, 2024
@gopidesupavan@kunaljubce
Standard provider bash operator (apache#42252)
42f69cc
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
@gopidesupavan@pavansharma36
Standard provider bash operator (apache#42252)
d35d174
@potiukpotiuk mentioned this pull request Oct 14, 2024
Merged
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
@gopidesupavanLorin
Standard provider bash operator (apache#42252)
c1ef8c5
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@potiuk@joaopamaral
Add standard provider to chicken-egg-providers (apache#42760)
9093357
Standard provider should be added to chicken-egg-providers as it
has not yet been officially released, so we need to add it.
This can only be done via "apache" PR as it is needed in build-images
workflow. This is needed to unblock apache#42252
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
@potiuk@harjeevanmaan
Add standard provider to chicken-egg-providers (apache#42760)
96cb9f7
Standard provider should be added to chicken-egg-providers as it
has not yet been officially released, so we need to add it.
This can only be done via "apache" PR as it is needed in build-images
workflow. This is needed to unblock apache#42252
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
@gopidesupavan@harjeevanmaan
Standard provider bash operator (apache#42252)
bb1b0bd
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
@gopidesupavan@PaulKobow7536
Standard provider bash operator (apache#42252)
0b34cb9
@potiukpotiuk mentioned this pull request Nov 1, 2024
Closed
1 task
This was referenced Nov 2, 2024
Merged
Closed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@potiuk@ellisms
Add standard provider to chicken-egg-providers (apache#42760)
703fce7
Standard provider should be added to chicken-egg-providers as it
has not yet been officially released, so we need to add it.
This can only be done via "apache" PR as it is needed in build-images
workflow. This is needed to unblock apache#42252
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@gopidesupavan@ellisms
Standard provider bash operator (apache#42252)
d4d8459
@eladkaleladkal mentioned this pull request Nov 14, 2024
Closed
@gopidesupavan
gopidesupavan deleted the standard-provider-bash-operator branch November 23, 2024 19:53
@amoghrajeshamoghrajesh mentioned this pull request Jan 29, 2025
Merged
@Lee-WLee-W mentioned this pull request Feb 3, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jedcunninghamjedcunninghamjedcunningham left review comments
@romsharon98romsharon98romsharon98 approved these changes
@jscheffljscheffljscheffl approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@dstandishdstandishAwaiting requested review from dstandish
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@kaxilkaxilAwaiting requested review from kaxil

Assignees

No one assigned

Labels

area:dev-toolsarea:providersprovider:celeryprovider:openlineageAIP-53

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gopidesupavan@jscheffl@ashb@potiuk@romsharon98@jedcunningham