Uh oh!
There was an error while loading. Please reload this page.
Moving EmptyOperator to standard provider - #46231
Conversation
eladkal
commented
Jan 29, 2025
It needs newsfragment as breaking change for Airflow 3 |
amoghrajesh
commented
Jan 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
amoghrajesh
commented
Jan 31, 2025
@potiuk it'd be nice if you can take a look on this too, since you were involved in the past standard operator moves |
sunank200
left a comment
There was a problem hiding this comment.
Overall LGTM. Added few comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
amoghrajesh
commented
Jan 31, 2025
Lee-W
commented
Feb 3, 2025
amoghrajesh
commented
Feb 3, 2025
@vincbeck we will be adding the migration rules for this as requested. @sunank200 / @Lee-W will be assisting with that. |
eladkal
commented
Feb 3, 2025
You can deploy dag in zip files. |
Lee-W
commented
Feb 3, 2025
@amoghrajesh Is it possible for us to zip it through script instead of just uploading a zip file? It's hard to know what's actually inside the zip |
amoghrajesh
commented
Feb 3, 2025
It does yeah, it contains a reference to the older EmptyOperator path, i updated that |
amoghrajesh
commented
Feb 3, 2025
Hmm, its been done this way historically too, I guess we can but I can do it in a follow up if thats ok? I will list the zip changes here: |
Lee-W
commented
Feb 3, 2025
Yep, I know it's done this way previously. If this is blocking something, we can create an issue for tracking this and do it in follow up PRs. Thanks! |
amoghrajesh
commented
Feb 3, 2025
Yeah, will pick it up @Lee-W. |
Lee-W
commented
Feb 4, 2025
@amoghrajesh Sorry for the CI error. The fix is created #46404 |
amoghrajesh
commented
Feb 4, 2025
No problem, thanks! I was wondering what the issue was! |
Lee-W
commented
Feb 4, 2025
Feel free to resolve my comments. I think we're close to merge 🙂 |
Basic dag tested:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.