Rename dataset endpoints as asset endpoints by Lee-W · Pull Request #42579 · apache/airflow

Lee-W · 2024-09-30T02:35:52Z

Rename dataset endpoints as asset endpoints
- Rename /datasets as /assets
- Rename /datasets/{uri} as /assets/{uri}
- Rename /datasets/events as /assets/events
- Rename /datasets/queuedEvent/{uri} as /ui/next_run_assets/upstream
- Rename /dags/{dag_id}/dagRuns/{dag_run_id}/upstreamDatasetEvents as /ui/next_run_assets/upstream
- Rename /dags/{dag_id}/datasets/queuedEvent/{uri} as /ui/next_run_assets/upstream
- Rename /dags/{dag_id}/datasets/queuedEvent as /ui/next_run_assets/upstream
- Rename /ui/next_run_datasets/upstream as /ui/next_run_assets/upstream
Rename dataset schema as asset endpoints
- Rename AssetCollection.datasets as AssetCollection.assets
- Rename AssetEventCollection.dataset_events as AssetEventCollection.asset_events
- Rename AssetEventCollectionSchema.dataset_events as AssetEventCollectionSchema.asset_events
- Rename CreateAssetEventSchema.dataset_uri as CreateAssetEventSchema.asset_uri

Some of the names are still kept as Dataset due to the database not being changed. will be handled in #42023

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…rename

bbovenzi

Functionality lgtm

There's still variable names and places in the UI that use the name "dataset". But it is all deprecated so that's fine by me. Once we upgrade the db columns, let's make sure no mention of dataset finds its way into /api_fastapi and /ui directories.

Lee-W · 2024-10-03T10:05:58Z

Functionality lgtm
There's still variable names and places in the UI that use the name "dataset". But it is all deprecated so that's fine by me. Once we upgrade the db columns, let's make sure no mention of dataset finds its way into /api_fastapi and /ui directories.

Sure! The next PR I'll work on is the DB one. once that's merged, I think we can get rid of the dataset in /api_fastapi and /ui. After that, I'll work on the rest of the UI thing, and everything has not yet changed

jscheffl · 2024-10-04T14:20:08Z

Assuming post-merge this PR broke canary tests on main - can you take a look for fixing? https://github.com/apache/airflow/actions/runs/11175856695/job/31068286744

* feat(api_connexion): rename dataset_endpoint module as asset_endpoint * feat(api_connexion/openapi): rename tag Dataset as Asset * feat(api_connexion): rename create_dataset_event as create_asset_event * feat(api_connexion): rename schema CreateDatasetEvent as CreateAssetEvent * test(api_connexion): rename test_dataset_endpoint as test_asset_endpoint * feat(api_connexion): rename delete_dataset_queued_events as delete_asset_queued_events * feat(api_connexion): rename get_dataset_queued_events as get_asset_queued_events * feat(api_connexion): rename delete_dag_dataset_queued_events as delete_dag_asset_queued_events * feat(api_connexion): rename delete_dag_dataset_queued_event as delete_dag_asset_queued_event * feat(api_connexion): rename get_dag_dataset_queued_events as get_dag_asset_queued_events * feat(api_connexion): rename get_dag_dataset_queued_event as get_dag_asset_queued_event * refactor(api_connexion): remove unused dataset_id in _generate_queued_event_where_clause * feat(api_connexion): rename get_dataset_events as get_asset_events * feat(api_connexion): rename get_datasets as get_assets * feat(api_connexion): rename get_dataset as get_asset * feat(api_connexion/openapi): update api docs * feat(js): rename DatasetEvents as AssetEvents * feat(js): rename DatasetDetails as AssetDetails * feat(js): rename DatasetList as AssetList * feat(js/api): rename useUpstreamDatasetEvents as useUpstreamAssetEvents * feat(js/api): rename useDatasetsSummary as useAssetsSummary * feat(js/api): rename useDatasetDependencies as useAssetDependencies * feat(js/api): rename useDatasetEvents as useAssetEvents * feat(js/api): rename useDatasets as useAssets * feat(js/api): rename useDataset as useAsset * feat(api_connexion): rename get_upstream_dataset_events as get_upstream_asset_events * feat(api_connexion/openapi/v1): rename DatasetURI as AssetURI * feat(api_connexion/openapi/v1): rename DatasetCollection as AssetCollection * feat(api_connexion/openapi/v1): rename DagScheduleDatasetReference as DagScheduleAssetReference * feat(api_connexion/openapi/v1): rename TaskOutletDatasetReference as TaskOutletAssetReference * feat(js/api): rename DatasetEventCollection as AssetEventCollection * feat(api_connexion/openapi/v1): rename DatasetEvent as AssetEvent * feat(api_connexion/openapi/v1): rename Dataset as Asset * docs(api_connexion/openapi/v1): update dataset to asset in v1.yaml * feat(api_connexion): rename endpoint datasets as assets * test(api_connexion): rename dataset as asset * fix(api_connexion/openapi/v1): fix queued_events property name error * feat(api_fastapi): rename next_run_datasets as next_run_assets * test: resolve test conflict * docs(newsfragments): add newsfragments for dataset to asset endpoint rename * feat(js/api): rename datasetEvents as assetEvents * feat(js/api): rename variable datasetEvent as assetEvent * feat(js/api): rename dataset_api as asset_api

boring-cyborgBot added area:API Airflow's REST/HTTP API area:Scheduler including HA (high availability) scheduler labels Sep 30, 2024

Lee-W mentioned this pull request Sep 30, 2024
Rename "Dataset" as Asset #42307
Closed
2 tasks

Lee-W force-pushed the rename-dataset-as-asset-api branch 9 times, most recently from 5af121f to 6b170e0Compare October 2, 2024 06:31

uranusjr reviewed Oct 2, 2024
View reviewed changes

Comment threadairflow/api_connexion/endpoints/asset_endpoint.py Outdated

Lee-W force-pushed the rename-dataset-as-asset-api branch 2 times, most recently from 6be206a to beba573Compare October 2, 2024 13:29

Lee-W added the AIP-74 Dataset -> Asset label Oct 2, 2024

Lee-W changed the title ~~Rename dataset as asset api~~Rename dataset endpoints as asset endpointsOct 2, 2024

Lee-W force-pushed the rename-dataset-as-asset-api branch from beba573 to 159e7e8Compare October 2, 2024 13:33

Lee-W marked this pull request as ready for review October 2, 2024 13:34

Lee-W requested review from ashb, bbovenzi, ephraimbuddy, jscheffl, pierrejeambrun and ryanahamilton as code owners October 2, 2024 13:34

vincbeck reviewed Oct 2, 2024
View reviewed changes

Lee-W force-pushed the rename-dataset-as-asset-api branch from 159e7e8 to 72d3df2Compare October 2, 2024 21:51

Lee-W added 3 commits October 3, 2024 06:55

feat(api_connexion): rename dataset_endpoint module as asset_endpoint
04c286e

feat(api_connexion/openapi): rename tag Dataset as Asset
3a989d4

feat(api_connexion): rename create_dataset_event as create_asset_event
45faf05

Lee-W added 11 commits October 3, 2024 06:55

feat(api_connexion/openapi/v1): rename DatasetEvent as AssetEvent
a50b4c5

feat(api_connexion/openapi/v1): rename Dataset as Asset
70e14f8

docs(api_connexion/openapi/v1): update dataset to asset in v1.yaml
1d1c80c

feat(api_connexion): rename endpoint datasets as assets
9982a6d

test(api_connexion): rename dataset as asset
8c82e8a

fix(api_connexion/openapi/v1): fix queued_events property name error
7c2ba6a

feat(api_fastapi): rename next_run_datasets as next_run_assets
729314e

test: resolve test conflict
d0c08df

docs(newsfragments): add newsfragments for dataset to asset endpoint …
bd3ddfa
…rename

feat(js/api): rename datasetEvents as assetEvents
6eb5d29

feat(js/api): rename variable datasetEvent as assetEvent
2eaff90

Lee-W requested review from sunank200 and uranusjr October 3, 2024 08:45

bbovenzi reviewed Oct 3, 2024
View reviewed changes

Comment threadairflow/api_fastapi/views/ui/assets.py Outdated

bbovenzi reviewed Oct 3, 2024
View reviewed changes

Comment threadtests/api_fastapi/views/ui/test_assets.py Outdated

bbovenzi reviewed Oct 3, 2024
View reviewed changes

Comment threadairflow/www/static/js/api/useAsset.ts Outdated

feat(js/api): rename dataset_api as asset_api
d6054ba

Lee-W force-pushed the rename-dataset-as-asset-api branch from 72d3df2 to d6054baCompare October 3, 2024 09:20

bbovenzi approved these changes Oct 3, 2024
View reviewed changes

vincbeck approved these changes Oct 3, 2024
View reviewed changes

Lee-W merged commit ef981f1 into apache:mainOct 3, 2024

Lee-W deleted the rename-dataset-as-asset-api branch October 3, 2024 23:57

bugraoz93 mentioned this pull request Oct 4, 2024
Fix main Branch Test Failures #42744
Merged

Lee-W mentioned this pull request Nov 18, 2024
Airflow 2 to 3 auto migration rules #41641
Closed
2 tasks

potiuk mentioned this pull request Jan 16, 2025
Update existing significant newsfragments with the later introduced template format #45678
Merged

Navigation Menu

Uh oh!

Rename dataset endpoints as asset endpoints - #42579

Rename dataset endpoints as asset endpoints#42579
Lee-W merged 43 commits into
apache:mainfrom
astronomer:rename-dataset-as-asset-api

Lee-W commented Sep 30, 2024•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbovenzi left a comment •
edited
Loading

Uh oh!

Lee-W commented Oct 3, 2024

Uh oh!

jscheffl commented Oct 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Lee-W commented Sep 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbovenzi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lee-W commented Oct 3, 2024

Uh oh!

jscheffl commented Oct 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Lee-W commented Sep 30, 2024•
edited
Loading

bbovenzi left a comment •
edited
Loading