Uh oh!
There was an error while loading. Please reload this page.
Rename dataset as asset in UI - #43073
Merged
Merged
Conversation
Lee-Wforce-pushed
the
rename-dataset-as-asset-in-ui
branch
from
October 16, 2024 11:23
6bd7966 to
1513aceCompareLee-Wforce-pushed
the
rename-dataset-as-asset-in-ui
branch
12 times, most recently
from
October 21, 2024 10:46
cbaedd7 to
aad1ea8CompareLee-W
marked this pull request as ready for review
October 21, 2024 10:47
Lee-W
requested review from
XD-DENG, ashb, bbovenzi, bolkedebruin, ephraimbuddy, jscheffl, pierrejeambrun and ryanahamilton
as code ownersOctober 21, 2024 10:47
Lee-Wforce-pushed
the
rename-dataset-as-asset-in-ui
branch
from
October 22, 2024 09:34
28f27b2 to
6ccd484Comparebbovenzi
commented
Oct 22, 2024
Contributor
Would the backend not also have issues with backporting changes to 2.10/11? I do agree that much of this work isn't necessary because we will be removing the |
Lee-W
commented
Oct 23, 2024
MemberAuthor
Yep, whenever I need to do that kind of change, I just did them in separate branch instead of just backporting the merged commit.
Thanks for confirming. If it actually introduced bugs, I think it's better to just change it in main. I'll go ahead and merge it |
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* feat(airflow/www): rename DatasetEventCard as AssetEventCard * feat(airflow/www): rename DatasetUpdateEvents as AssetUpdateEvents * feat(airflow/www): rename DatasetTriggerEvents as AssetTriggerEvents * feat(airflow/www): rename DatasetNode as AssetNode * feat(airflow/www): rename getUpstreamDatasets as getUpstreamAssets * feat(airflow/www): rename DatasetDependencies as AssetDependencies * feat(airflow/www): rename upstreamDatasetEdges as upstreamAssetEdges * feat(airflow/www): rename DatasetListItem as AssetListItem * feat(airflow/www): rename DatasetGraph as AssetGraph * feat(airflow/www): rename DatasetsData as AssetsData * feat(airflow/www): rename dataset as asset in ts* files * feat(airflow): rename airflow/www/static/js/datasets/ as airflow/www/static/js/assets * feat(airflow/www): rename dataset as asset in js files * feat(airflow/www): rename dataset as asset in html files * test(www): rename test_views_dataset as test_views_asset * feat: rename dataset as asset in other files * docs: update screenshots * docs: add newsfragment
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* feat(airflow/www): rename DatasetEventCard as AssetEventCard * feat(airflow/www): rename DatasetUpdateEvents as AssetUpdateEvents * feat(airflow/www): rename DatasetTriggerEvents as AssetTriggerEvents * feat(airflow/www): rename DatasetNode as AssetNode * feat(airflow/www): rename getUpstreamDatasets as getUpstreamAssets * feat(airflow/www): rename DatasetDependencies as AssetDependencies * feat(airflow/www): rename upstreamDatasetEdges as upstreamAssetEdges * feat(airflow/www): rename DatasetListItem as AssetListItem * feat(airflow/www): rename DatasetGraph as AssetGraph * feat(airflow/www): rename DatasetsData as AssetsData * feat(airflow/www): rename dataset as asset in ts* files * feat(airflow): rename airflow/www/static/js/datasets/ as airflow/www/static/js/assets * feat(airflow/www): rename dataset as asset in js files * feat(airflow/www): rename dataset as asset in html files * test(www): rename test_views_dataset as test_views_asset * feat: rename dataset as asset in other files * docs: update screenshots * docs: add newsfragment
25 tasks
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* feat(airflow/www): rename DatasetEventCard as AssetEventCard * feat(airflow/www): rename DatasetUpdateEvents as AssetUpdateEvents * feat(airflow/www): rename DatasetTriggerEvents as AssetTriggerEvents * feat(airflow/www): rename DatasetNode as AssetNode * feat(airflow/www): rename getUpstreamDatasets as getUpstreamAssets * feat(airflow/www): rename DatasetDependencies as AssetDependencies * feat(airflow/www): rename upstreamDatasetEdges as upstreamAssetEdges * feat(airflow/www): rename DatasetListItem as AssetListItem * feat(airflow/www): rename DatasetGraph as AssetGraph * feat(airflow/www): rename DatasetsData as AssetsData * feat(airflow/www): rename dataset as asset in ts* files * feat(airflow): rename airflow/www/static/js/datasets/ as airflow/www/static/js/assets * feat(airflow/www): rename dataset as asset in js files * feat(airflow/www): rename dataset as asset in html files * test(www): rename test_views_dataset as test_views_asset * feat: rename dataset as asset in other files * docs: update screenshots * docs: add newsfragment
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #42307
Rename
DagRunTriggeredByType.DATASETasDagRunTriggeredByType.ASSETand all the namedatasetin all the UI components toasset.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.