Uh oh!
There was an error while loading. Please reload this page.
Remove deprecated hook code from plugins - #43291
Conversation
kaxil
commented
Oct 23, 2024
1e7cc79 to
a6b28d4CompareUh oh!
There was an error while loading. Please reload this page.
potiuk
commented
Oct 23, 2024
Should be fine. The plugins from Airlfow 2 will stop working anyway and people will have to modify them. This is pretty much a "given" incompatibility and we need to bite the bullet. But the test needs to be fixed and I think we should add a newsfragment (just one liner now and we can expand it later). |
a6b28d4 to
12e96bdCompare
That was already part of the docs though, check PR description -- should we still add a newsfragment? Our docs already mark this as removed in 2.0: ![]() airflow/docs/apache-airflow/authoring-and-scheduling/plugins.rst Lines 33 to 37 in 1568788 |
12e96bd to
e3e8b92Comparee3e8b92 to
b7fc435Compare
ashb
left a comment
There was a problem hiding this comment.
Yeah looks good to me.
I think an explicit news fragment is a good idea, even though the docs say it was deprecated this should be called out as finally breaking. (I'm thinking to the issue FAB/WTForms had recently, so lets be explicit when we can)
b7fc435 to
3f92bf7Comparekaxil
commented
Oct 23, 2024
Added in 3f92bf7 |
23740a9 to
8f6360cCompareWe had removed registering hooks via plugin in apache#12108 for Airflow 2.0. We kept it for registering Connection form. As I understand it, we don't use that code but `ProvidersManager` (`airflow/providers_manager.py`) to register Connections from providers.
8f6360c to
e46b311CompareWe had removed registering hooks via plugin in apache#12108 for Airflow 2.0. We kept it for registering Connection form. As I understand it, we don't use that code but `ProvidersManager` (`airflow/providers_manager.py`) to register Connections from providers.
We had removed registering hooks via plugin in apache#12108 for Airflow 2.0. We kept it for registering Connection form. As I understand it, we don't use that code but `ProvidersManager` (`airflow/providers_manager.py`) to register Connections from providers.
We had removed registering hooks via plugin in apache#12108 for Airflow 2.0. We kept it for registering Connection form. As I understand it, we don't use that code but `ProvidersManager` (`airflow/providers_manager.py`) to register Connections from providers.

We had removed registering hooks via plugin in #12108 for Airflow 2.0. We kept it for registering Connection form.
As I understand it, we don't use that code but
ProvidersManager(airflow/providers_manager.py) to register Connections from providers.Our docs already mark this as removed in 2.0:
airflow/docs/apache-airflow/authoring-and-scheduling/plugins.rst
Lines 33 to 37 in 1568788
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.