Skip to content

AIP-84 Migrate public xcom endpoint get entry to fastapi - #43521

Merged
pierrejeambrun merged 5 commits into
apache:mainfrom
michaeljs-c:migrate-xcom-getentry-to-fastapi
Nov 12, 2024
Merged

AIP-84 Migrate public xcom endpoint get entry to fastapi#43521
pierrejeambrun merged 5 commits into
apache:mainfrom
michaeljs-c:migrate-xcom-getentry-to-fastapi

Conversation

@michaeljs-c

@michaeljs-cmichaeljs-c commented Oct 30, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

closes#42978

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@michaeljs-c
michaeljs-c marked this pull request as ready for review October 30, 2024 18:26
@michaeljs-c
michaeljs-cforce-pushed the migrate-xcom-getentry-to-fastapi branch from b107d68 to 37e36a4CompareOctober 31, 2024 23:15
pierrejeambrun
pierrejeambrun reviewed Nov 4, 2024
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Overall looking nice, a few minor suggestions.

We are missing the mark_fastapi_migration_done, check �17_adding_api_endpoints.rst for more information.

Comment threadairflow/api_fastapi/core_api/routes/public/xcom.py Outdated
Comment threadairflow/api_fastapi/core_api/routes/public/xcom.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_xcom.py Outdated
@michaeljs-c
michaeljs-cforce-pushed the migrate-xcom-getentry-to-fastapi branch from a48ad67 to 73a95e3CompareNovember 6, 2024 22:57
@michaeljs-c

michaeljs-c commented Nov 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you for the PR. Overall looking nice, a few minor suggestions.

We are missing the mark_fastapi_migration_done, check �17_adding_api_endpoints.rst for more information.

Thanks for the comments. I've updated the PR. It looks like adding the migration decorator caused CI to fail due to changes in the legacy API requiring a legacy tag?

pierrejeambrun
pierrejeambrun approved these changes Nov 8, 2024
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change in how we define routes. TLDR we should not use async.

More info here #43797

I just pushed a commit to remove the async so we can merge.

Thanks again for your contribution. 🎉

Comment threadairflow/api_fastapi/core_api/routes/public/xcom.py Outdated
@pierrejeambrunpierrejeambrun added the legacy api Whether legacy API changes should be allowed in PR label Nov 8, 2024
@pierrejeambrun

pierrejeambrun commented Nov 8, 2024

Copy link
Copy Markdown
Member

@michaeljs-c Can you please rebase and solve conflicts, we are good to merge after that :)

@michaeljs-c
michaeljs-cforce-pushed the migrate-xcom-getentry-to-fastapi branch from 3a48142 to 0b2b68fCompareNovember 8, 2024 22:06
@michaeljs-c

michaeljs-c commented Nov 8, 2024

Copy link
Copy Markdown
ContributorAuthor

@michaeljs-c Can you please rebase and solve conflicts, we are good to merge after that :)

All done. Thanks @pierrejeambrun!

@pierrejeambrun
pierrejeambrun merged commit 5bb9221 into apache:mainNov 12, 2024
@pierrejeambrunpierrejeambrun added the AIP-84 Modern Rest API label Nov 12, 2024
@pierrejeambrunpierrejeambrun changed the title Migrate public xcom endpoint get entry to fastapiAIP-84 Migrate public xcom endpoint get entry to fastapiNov 12, 2024
@pierrejeambrunpierrejeambrun mentioned this pull request Nov 12, 2024
Merged
sunank200 pushed a commit to astronomer/airflow that referenced this pull request Nov 12, 2024
@michaeljs-c@pierrejeambrun@sunank200
Migrate public xcom endpoint get entry to fastapi (apache#43521)
82e9013
* Migrate public xcom get entry to fastapi
* Update date parse call
* add migration decorator, update params and test
* Minor adjustment
* Fix import and api spec
---------
Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
@pierrejeambrunpierrejeambrun mentioned this pull request Nov 12, 2024
Merged
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@michaeljs-c@pierrejeambrun@ellisms
Migrate public xcom endpoint get entry to fastapi (apache#43521)
d73c298
* Migrate public xcom get entry to fastapi
* Update date parse call
* add migration decorator, update params and test
* Minor adjustment
* Fix import and api spec
---------
Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
@pierrejeambrunpierrejeambrun added this to the Airflow 3.0.0 milestone Nov 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy

Assignees

No one assigned

Labels

AIP-84Modern Rest APIlegacy apiWhether legacy API changes should be allowed in PR

Projects

No open projects
AIP-84 MODERN REST API
Status: Done

Milestone

Airflow 3.0.0

Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate XCom get entry public endpoint to FastAPI

2 participants

@michaeljs-c@pierrejeambrun