Skip to content

Fix main pre-commit - #43923

Merged
potiuk merged 1 commit into
apache:mainfrom
astronomer:fix-main-pre-commit
Nov 12, 2024
Merged

Fix main pre-commit#43923
potiuk merged 1 commit into
apache:mainfrom
astronomer:fix-main-pre-commit

Conversation

@pierrejeambrun

Copy link
Copy Markdown
Member

No description provided.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 12, 2024
@ashb

ashb commented Nov 12, 2024

Copy link
Copy Markdown
Member

Do we need to fix up the selective check logic?

https://github.com/apache/airflow/actions/runs/11750492342/job/32738823728?pr=43521#step:8:878

skip-pre-commits = ...,ts-compile-format-lint-ui,ts-compile-format-lint-www

https://github.com/apache/airflow/blob/main/dev/breeze/src/airflow_breeze/utils/selective_checks.py#L1077-L1133 will need updating.

@pierrejeambrun

pierrejeambrun commented Nov 12, 2024

Copy link
Copy Markdown
MemberAuthor

Do we need to fix up the selective check logic?

Yes, something must be wrong in those, the ts-compile-format-lint-ui shouldn't be skipped in #43521

@potiuk
potiuk merged commit 33dfb73 into apache:mainNov 12, 2024
@pierrejeambrun
pierrejeambrun deleted the fix-main-pre-commit branch November 12, 2024 12:00
sunank200 pushed a commit to astronomer/airflow that referenced this pull request Nov 12, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@pierrejeambrun@ashb@Lee-W@hussein-awala@amoghrajesh@potiuk