Uh oh!
There was an error while loading. Please reload this page.
Test standard provider with Airflow 2.8 and 2.9 - #43556
Conversation
potiuk
commented
Oct 31, 2024
Ha.... so we are NOT good with standard provider for 2.8 and 2.9 YET |
ab92765 to
4ce61b3Comparegopidesupavan
commented
Oct 31, 2024
hm sorry my bad 😞 , i thought only on airflow 2.10 |
potiuk
commented
Oct 31, 2024
No worries :). Nice excercise to fix it for 2.8 and 2.9 :) |
d226946 to
4e2c7e8CompareUh oh!
There was an error while loading. Please reload this page.
1a558cc to
630eb6fCompare630eb6f to
7e8159aComparepotiuk
commented
Nov 3, 2024
There are still some interesting problems to solve :). I already found another teething problem from providers move :) |
99ad6f7 to
77e9f92Compare7021195 to
6ad6365CompareUh oh!
There was an error while loading. Please reload this page.
6ad6365 to
5e2c180Comparegopidesupavan
commented
Nov 7, 2024
alright got it where the failures coming from for this 2.10 has this casting Context: https://github.com/apache/airflow/blob/v2-10-stable/airflow/serialization/serialized_objects.py#L829, where as 2.8 and 2.9 doesn't have this implementation. |
potiuk
commented
Nov 8, 2024
Nice. Good job. So now we have to find out how this deserialization happened in 2.8/2.9 PythonVirtualenv. Let me take a look |
potiuk
commented
Nov 8, 2024
AH... Of course. Sending context was added in 3.0.0 :) . So the fact that it actually works on 2.10 is a bonus of new standard providers, but there should be no expectation it should work on 2.8 or 2.9 because it never worked there! |
gopidesupavan
commented
Nov 8, 2024
Yeah that's correct, should we make necessary changes to support it only for 2.10+ |
gopidesupavan
commented
Nov 8, 2024
Happy to make changes, I believe only need some test fixes and use_airflow_context |
potiuk
commented
Nov 8, 2024
I am fixing it :) |
f15c40e to
1e25069Comparepotiuk
commented
Nov 8, 2024
Actually - really the thing is that that it was only working on 2.10 when ENABLE_AIP_44 was used, so we really should only enable it only for Airlfow 3+ |
1e25069 to
de13808Comparegopidesupavan
commented
Nov 8, 2024
Yes your correct. for airflow less thank 3 versions we can disable, currently by default its coming as true for all the versions. I ran this in local , raised change here: #43818 |
bf8f2e6 to
34789e6CompareThe standard provider has now min version of Airflow = 2.8 since apache#43553, but we have not tested it for Airflow 2.8 and 2.9.
34789e6 to
b8c297dComparepotiuk
commented
Nov 9, 2024
@gopidesupavan - you can rebase and check yout #43818 now |
gopidesupavan
commented
Nov 9, 2024
woohoo merged thank you @potiuk :) . Let me rebase other pr. |
The standard provider has now min version of Airflow = 2.8 since apache#43553, but we have not tested it for Airflow 2.8 and 2.9.
| from __future__ import annotations | ||
| from packaging.version import Version | ||
| from airflow import __version__ as airflow_version | ||
| AIRFLOW_VERSION = Version(airflow_version) | ||
| AIRFLOW_V_2_10_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("2.10.0") | ||
| AIRFLOW_V_3_0_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("3.0.0") |
There was a problem hiding this comment.
This will be overridden during release time as the provider __init__ is generated from template.
The standard provider has now min version of Airflow = 2.8 since #43553, but we have not tested it for Airflow 2.8 and 2.9.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.