Skip to content

AIP-84 Migrating GET ASSETS Legacy API to fastAPI - #43783

Merged
pierrejeambrun merged 16 commits into
apache:mainfrom
astronomer:AIP84-get-asset-to-fastapi
Nov 12, 2024
Merged

AIP-84 Migrating GET ASSETS Legacy API to fastAPI#43783
pierrejeambrun merged 16 commits into
apache:mainfrom
astronomer:AIP84-get-asset-to-fastapi

Conversation

@amoghrajesh

@amoghrajeshamoghrajesh commented Nov 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

related: #42370
Migrating the connexion API for GET ASSETS to fastAPI.

Testing performed:

  1. Created 2 pairs of DAGS each linking to different assets
    image

  2. API responses using legacy and fastAPI endpoints (one example with all params used)

Legacy API:
image

Fast API:
image

Swagger Spec:
image

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 7, 2024
@pierrejeambrunpierrejeambrun added legacy api Whether legacy API changes should be allowed in PR AIP-84 Modern Rest API labels Nov 7, 2024
jedcunningham
jedcunningham reviewed Nov 7, 2024
View reviewed changes
Comment threadairflow/api_fastapi/common/parameters.py Outdated
@amoghrajesh
amoghrajesh marked this pull request as ready for review November 8, 2024 05:30
@amoghrajesh@jedcunningham
Update airflow/api_fastapi/common/parameters.py
428cb6c
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
amoghrajesh
amoghrajesh commented Nov 8, 2024
View reviewed changes
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py Outdated
Comment threadairflow/api_fastapi/common/parameters.py Outdated
@amoghrajesh

amoghrajesh commented Nov 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Okay seems like the dag_ids filter doesn't work yet. FIxing it

ephraimbuddy
ephraimbuddy reviewed Nov 8, 2024
View reviewed changes
Comment threadairflow/api_fastapi/common/parameters.py Outdated
This was referenced Nov 8, 2024
Closed
Merged
@pierrejeambrunpierrejeambrun changed the title AIP 84: Migrating GET ASSETS Legacy API to fastAPIAIP-84 Migrating GET ASSETS Legacy API to fastAPINov 8, 2024
pierrejeambrun
pierrejeambrun reviewed Nov 8, 2024
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, thanks.

Need rebasing to solve conflicts, small nitpicks.

Comment threadairflow/api_fastapi/core_api/routes/public/assets.py Outdated
Comment threadairflow/api_fastapi/common/parameters.py
Comment threadairflow/api_fastapi/common/parameters.py Outdated
Comment threadairflow/api_fastapi/core_api/routes/public/assets.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py Outdated
@amoghrajesh

amoghrajesh commented Nov 8, 2024

Copy link
Copy Markdown
ContributorAuthor

With the latest commits, most of the things should be taken care of.
@pierrejeambrun and @ephraimbuddy addressed your comments

@pierrejeambrun

pierrejeambrun commented Nov 8, 2024

Copy link
Copy Markdown
Member

Thanks, don't hesitate to resolve conversation that you have adressed. I'm out of office until tuesday. (Bank holiday in france)

@amoghrajeshamoghrajesh mentioned this pull request Nov 11, 2024
Merged
@vatsrahul1001vatsrahul1001 mentioned this pull request Nov 11, 2024
Merged
phanikumv
phanikumv approved these changes Nov 12, 2024
View reviewed changes

@phanikumvphanikumv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

pierrejeambrun
pierrejeambrun approved these changes Nov 12, 2024
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks ! 🎉

@pierrejeambrun
pierrejeambrun merged commit 3217576 into apache:mainNov 12, 2024
@pierrejeambrun
pierrejeambrun deleted the AIP84-get-asset-to-fastapi branch November 12, 2024 16:04
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@amoghrajesh@jedcunningham@ellisms
AIP-84 Migrating GET ASSETS Legacy API to fastAPI (apache#43783)
42746e0
* AIP-84: Migrating GET Assets to fastAPI
* matching response to legacy
* Adding unit tests - part 1
* Update airflow/api_fastapi/common/parameters.py
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
* fixing the dag_ids filter
* fixing the dag_ids filter
* Adding unit tests - part 2
* fixing unit tests & updating parameter type
* review comments pierre
* fixing last commit
* fixing unit tests
---------
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@phanikumvphanikumvphanikumv approved these changes
@bbovenzibbovenziAwaiting requested review from bbovenzi
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@jscheffljschefflAwaiting requested review from jscheffl
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham

Assignees

@pierrejeambrunpierrejeambrun

@amoghrajeshamoghrajesh

Labels

AIP-84Modern Rest APIarea:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.legacy apiWhether legacy API changes should be allowed in PR

Projects

No open projects
AIP-84 MODERN REST API
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amoghrajesh@pierrejeambrun@ephraimbuddy@jedcunningham@phanikumv