AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI by amoghrajesh · Pull Request #43874 · apache/airflow

amoghrajesh · 2024-11-11T10:16:16Z

Depends on #43783

Migrating the GET Dataset events for DAG runs to fastAPI

Responses:
Legacy

FastAPI

Swagger spec

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

amoghrajesh · 2024-11-11T10:16:31Z

Only the last 3 commits are relevant here

…ts-dagrun

pierrejeambrun · 2024-11-12T17:02:54Z

The base branch has been merged, branch needs rebasing.

Also you can add the legacy api tag to allow the CI to build.

pierrejeambrun

Nice just a couple of comments.

I'll do a final in depth review when the branch is rebased, it will make the review easier to only have the 'definitive' diff and not also the one from the base branch.

pierrejeambrun

Thanks, a few suggestions

pierrejeambrun

One small suggestion following the change of convention based on Kaxil's PR that was just merged yesterday.

Otherwise looking good and ready to merge.

Thanks

amoghrajesh · 2024-11-14T16:02:33Z

OK i got a green CI. Is this one good to merge @pierrejeambrun?

pierrejeambrun

Needs rebasing, small need and ready to merge.

pierrejeambrun · 2024-11-15T16:17:56Z

Thanks 🎉

…che#43874) * AIP-84: Migrating GET Assets to fastAPI * matching response to legacy * Adding unit tests - part 1 * Update airflow/api_fastapi/common/parameters.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * fixing the dag_ids filter * fixing the dag_ids filter * Adding unit tests - part 2 * fixing unit tests & updating parameter type * review comments pierre * fixing last commit * fixing unit tests * AIP-84: Migrating GET Dataset events for DAG runs to fastAPI * adding test cases * adding test cases * review comments pierre * fixing unit tests * review comments pierre * review comments and fixing a test * review comments on ut --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

amoghrajeshand others added 17 commits November 6, 2024 15:22

AIP-84: Migrating GET Assets to fastAPI
cf5218c

matching response to legacy
5a49280

Adding unit tests - part 1
962572b

Update airflow/api_fastapi/common/parameters.py
428cb6c
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

fixing the dag_ids filter
a78d3cb

fixing the dag_ids filter
882d20c

Adding unit tests - part 2
25bb08e

Merge branch 'main' into AIP84-get-asset-to-fastapi
658479d

fixing unit tests & updating parameter type
fa0cd23

review comments pierre
dd791c2

fixing last commit
06fa0a7

Merge branch 'main' into AIP84-get-asset-to-fastapi
3bd803b

Merge branch 'main' into AIP84-get-asset-to-fastapi
fc29d7d

fixing unit tests
7a97220

AIP-84: Migrating GET Dataset events for DAG runs to fastAPI
df1ff8e

adding test cases
6c80ced

adding test cases
e344263

amoghrajesh requested review from bbovenzi, ephraimbuddy, jscheffl, pierrejeambrun and ryanahamilton as code owners November 11, 2024 10:16

boring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 11, 2024

amoghrajesh added 3 commits November 12, 2024 17:10

Merge branch 'main' into AIP84-get-asset-to-fastapi
0df9ebd

Merge branch 'main' into AIP84-get-asset-to-fastapi
5fb8bc1

Merge branch 'AIP84-get-asset-to-fastapi' into AIP84-get-dataset-even…
6426b0b
…ts-dagrun

pierrejeambrun added the AIP-84 Modern Rest API label Nov 12, 2024

pierrejeambrun reviewed Nov 12, 2024
View reviewed changes

Comment threadairflow/api_fastapi/core_api/routes/public/dag_run.py Outdated
Comment threadairflow/api_fastapi/core_api/datamodels/assets.py Outdated

amoghrajesh added the legacy api Whether legacy API changes should be allowed in PR label Nov 13, 2024

Merge branch 'main' into AIP84-get-dataset-events-dagrun
80c4da0

amoghrajesh self-assigned this Nov 13, 2024

amoghrajesh added 2 commits November 13, 2024 12:56

review comments pierre
e7b96aa

fixing unit tests
c4d7dfc

amoghrajesh mentioned this pull request Nov 13, 2024
AIP-84 Migrate public endpoints from api_connexion to the new Rest API #42370
Closed
1 task

pierrejeambrun reviewed Nov 13, 2024
View reviewed changes

Comment threadairflow/api_fastapi/core_api/datamodels/assets.py Outdated
Comment threadairflow/api_fastapi/core_api/datamodels/assets.py Outdated
Comment threadairflow/api_fastapi/core_api/datamodels/assets.py Outdated

amoghrajesh added 2 commits November 14, 2024 09:45

Merge branch 'main' into AIP84-get-dataset-events-dagrun
e269dd3

review comments pierre
0da44d0

amoghrajesh mentioned this pull request Nov 14, 2024
Remove ORM references from datamodels for assets #44010
Merged

amoghrajesh requested a review from pierrejeambrun November 14, 2024 08:23

Merge branch 'main' into AIP84-get-dataset-events-dagrun
75a387e

pierrejeambrun reviewed Nov 14, 2024
View reviewed changes

Comment threadairflow/api_fastapi/core_api/routes/public/dag_run.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_dag_run.py

amoghrajesh mentioned this pull request Nov 14, 2024
Add a date formatter for new public API test cases #44033
Closed
1 task

review comments and fixing a test
f93032c

amoghrajesh requested a review from pierrejeambrun November 14, 2024 15:44

rawwar reviewed Nov 14, 2024
View reviewed changes

Comment threadtests/api_fastapi/core_api/routes/public/test_dag_run.py

This was referenced Nov 14, 2024
AIP-84 Migrate GET asset event for a Dag Run endpoint to FastAPI #43876
Closed
AIP-84 Migrate Dag Run related public endpoint to FastAPI #42701
Closed

pierrejeambrun approved these changes Nov 15, 2024
View reviewed changes

Comment threadtests/api_fastapi/core_api/routes/public/test_dag_run.py Outdated

amoghrajesh added 2 commits November 15, 2024 20:16

Merge branch 'main' into AIP84-get-dataset-events-dagrun
13dff1c

review comments on ut
6ff2fdd

pierrejeambrun merged commit 0f14f66 into apache:mainNov 15, 2024

pierrejeambrun deleted the AIP84-get-dataset-events-dagrun branch November 15, 2024 16:18

Navigation Menu

Uh oh!

AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI - #43874

AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI#43874
pierrejeambrun merged 29 commits into
apache:mainfrom
astronomer:AIP84-get-dataset-events-dagrun

amoghrajesh commented Nov 11, 2024

Uh oh!

amoghrajesh commented Nov 11, 2024

Uh oh!

pierrejeambrun commented Nov 12, 2024•
edited
Loading

Uh oh!

pierrejeambrun left a comment •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

Uh oh!

amoghrajesh commented Nov 14, 2024

Uh oh!

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

pierrejeambrun commented Nov 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amoghrajesh commented Nov 11, 2024

Uh oh!

amoghrajesh commented Nov 11, 2024

Uh oh!

pierrejeambrun commented Nov 12, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amoghrajesh commented Nov 14, 2024

Uh oh!

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pierrejeambrun commented Nov 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pierrejeambrun commented Nov 12, 2024•
edited
Loading

pierrejeambrun left a comment •
edited
Loading