Uh oh!
There was an error while loading. Please reload this page.
AIP-84 Migrate Trigger Dag Run endpoint to FastAPI - #43875
Merged
pierrejeambrun merged 21 commits intoNov 27, 2024
Merged
Conversation
12 tasks
rawwarforce-pushed
the
kalyan/AIP-84/trigger_dag_run
branch
from
November 20, 2024 04:02
b11977f to
ed49619Comparerawwar
commented
Nov 20, 2024
Uh oh!
There was an error while loading. Please reload this page.
…AIP-84/trigger_dag_run
…AIP-84/trigger_dag_run
rawwar
commented
Nov 21, 2024
Uh oh!
There was an error while loading. Please reload this page.
rawwar
commented
Nov 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rawwar
marked this pull request as ready for review
November 22, 2024 17:31
rawwar
requested review from
ephraimbuddy, jscheffl and ryanahamilton
as code ownersNovember 22, 2024 17:31
…AIP-84/trigger_dag_run
Uh oh!
There was an error while loading. Please reload this page.
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Thanks looking good overall. A few suggestions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rawwar
commented
Nov 26, 2024
Uh oh!
There was an error while loading. Please reload this page.
pierrejeambrun
approved these changes
Nov 26, 2024
pierrejeambrun
approved these changes
Nov 27, 2024
ArshiaZr pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
* init * wip * remove logical_date * fix trigger dag_run * tests WIP * working tests * remove logical_date from post body * remove logical_date from tests * fix * include return type * fix conf * feedback * fix tests * Update tests/api_fastapi/core_api/routes/public/test_dag_run.py * feedback
got686-yandex pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* init * wip * remove logical_date * fix trigger dag_run * tests WIP * working tests * remove logical_date from post body * remove logical_date from tests * fix * include return type * fix conf * feedback * fix tests * Update tests/api_fastapi/core_api/routes/public/test_dag_run.py * feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #42701