Uh oh!
There was an error while loading. Please reload this page.
Add basic asyncio support - #43944
Conversation
tirkarthi
commented
Nov 13, 2024
Uh oh!
There was an error while loading. Please reload this page.
I think you prob know the answer. The AIP deals with asyncio, so yes strictly speaking related in that sense. But not "part of". That AIP has been in draft a long time not sure actively worked on. Anyway, I don't think what I'm doing here really requires an AIP. |
tirkarthi
commented
Nov 13, 2024
There is a similar draft PR open as POC for it though not active. So just wanted to confirm. Thanks for the details. |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Really exciting.
Do we want an @provide_async_session as a follow up ? (I think Ash wanted to kill that decorator at some point, even if I find it kind of useful actually)
ashb
commented
Nov 13, 2024
@pierrejeambrun A FastAPI dep to give an async session would be good, but I think anything in the models etc should be passed an explicit session. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
potiuk
commented
Nov 13, 2024
NICE! Yeah. I really like to see it working with mysql compatibility and benchmarks 📦 (because of course MySQL is our beloved database) |
dstandish
commented
Nov 13, 2024
i would say let's wait and see how / where / when we need it |
0af9d4d to
620902eCompareomkar-foss
commented
Nov 13, 2024
Lovely! Thank you for adding this, will try to start using this soon :) |
Uh oh!
There was an error while loading. Please reload this page.
5765c6c to
8b5ab77CompareThis is meant to be sort of a hello world for asyncio support in airflow. It will be refined and extended in the future. But I think airflow ultimately really needs to go in this direction: in the new REST API, in the new AIP-72 internal API server, in triggers, and ultimately, in the scheduler.
8b5ab77 to
6791e41Compareomkar-foss
commented
Nov 14, 2024
@dstandish in lowest direct dep tests, we may need to limit minimum version for More info on this slack thread. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is meant to be sort of a hello world for asyncio support in airflow. It will be refined and extended in the future. E.g. probably we would add more config flexibility re the libraries, connect args etc. But it's good to start simple.
Anyway, ultimately, I think Airflow really needs to go in this direction: in the new REST API, in the new AIP-72 internal API server, in triggers, and ultimately, in the scheduler.