Skip to content

Add task instance state and name filter to task instances tab in a dagrun - #45215

Merged
pierrejeambrun merged 7 commits into
apache:mainfrom
tirkarthi:task-instance-state-filter
Jan 20, 2025
Merged

Add task instance state and name filter to task instances tab in a dagrun#45215
pierrejeambrun merged 7 commits into
apache:mainfrom
tirkarthi:task-instance-state-filter

Conversation

@tirkarthi

@tirkarthitirkarthi commented Dec 26, 2024

Copy link
Copy Markdown
Contributor

A dagrun might have a lot of task instances that are paginated. This PR adds filters to filter by state e.g. failed task instances which is similar to the filter in dagrun page now. I have also added search by task_id or task_display_name so that users can quickly get to the required task instance in a paginated setting. Slightly related issues for grid view to search by name #32239 . This also updates the URLs so that it's shareable.

Notes for reviewer and self :

  • I reused the searchBar component but doesn't need advanced search as of now as it's not implemented and not useful here where search by task name is only needed. This can be added in future and the hideAdvanced part can be removed.

Screenshot :

image

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 26, 2024
jscheffl
jscheffl reviewed Dec 26, 2024
View reviewed changes
Comment threadairflow/ui/src/pages/Run/TaskInstances.tsx Outdated
Comment threadairflow/ui/src/pages/Run/TaskInstances.tsx
jscheffl
jscheffl approved these changes Dec 26, 2024
View reviewed changes

@jscheffljscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small nit in my view. Else: LGTM

Comment threadairflow/ui/src/pages/Run/TaskInstances.tsx Outdated
@tirkarthi
tirkarthiforce-pushed the task-instance-state-filter branch from 3a2fe8f to fe68b6fCompareDecember 26, 2024 11:02
@jscheffl

jscheffl commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

Note: As PR #45312 has been merged, the code formatting rules have changed for new UI. Please rebase and re-run pre-commit checks to ensure that formatting in folder airflow/ui is adjusted.

@tirkarthi
tirkarthiforce-pushed the task-instance-state-filter branch from fe68b6f to e2b6060CompareJanuary 5, 2025 14:11
pierrejeambrun
pierrejeambrun reviewed Jan 7, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working as expected and code looks good overall.

A few suggestion before merging.

Comment threadairflow/ui/src/pages/Run/TaskInstances.tsx
Comment threadairflow/ui/src/pages/Run/TaskInstances.tsx Outdated
Comment threadairflow/ui/src/components/SearchBar.tsx
Comment threadairflow/ui/src/pages/Run/TaskInstances.tsx
bbovenzi
bbovenzi reviewed Jan 7, 2025
View reviewed changes
Comment threadairflow/ui/src/pages/Run/TaskInstances.tsx Outdated
@tirkarthi
tirkarthiforce-pushed the task-instance-state-filter branch 2 times, most recently from 67746c6 to c67eec9CompareJanuary 9, 2025 09:00
@bbovenzi

bbovenzi commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

Lgmt looks like we need to rebase though

@tirkarthi
tirkarthiforce-pushed the task-instance-state-filter branch from c67eec9 to 2f6fd16CompareJanuary 15, 2025 05:16
@tirkarthi

tirkarthi commented Jan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

@bbovenzi Thanks, rebased and fixed conflicts.

@pierrejeambrun
pierrejeambrun merged commit c68083e into apache:mainJan 20, 2025
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
@tirkarthi@dauinh
Add task instance state and name filter to task instances tab in a da…
99899fe
…grun (apache#45215)
* Add state filter to task instances tab in dagrun page.
* Add tasks search in task instances page.
* Make dropdown clearable.
* Rebase and run format for line number rule.
* Add support for multiple state selection.
* Support no status for filtering.
* Fix rebase errors.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@tirkarthi@got686-yandex
Add task instance state and name filter to task instances tab in a da…
c15bdf7
…grun (apache#45215)
* Add state filter to task instances tab in dagrun page.
* Add tasks search in task instances page.
* Make dropdown clearable.
* Rebase and run format for line number rule.
* Add support for multiple state selection.
* Support no status for filtering.
* Fix rebase errors.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
@tirkarthi@niklasr22
Add task instance state and name filter to task instances tab in a da…
58ebe5a
…grun (apache#45215)
* Add state filter to task instances tab in dagrun page.
* Add tasks search in task instances page.
* Make dropdown clearable.
* Rebase and run format for line number rule.
* Add support for multiple state selection.
* Support no status for filtering.
* Fix rebase errors.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jscheffljscheffljscheffl approved these changes
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton

Assignees

No one assigned

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tirkarthi@jscheffl@bbovenzi@pierrejeambrun