Uh oh!
There was an error while loading. Please reload this page.
Change UI source formatting to 110 chars - #45312
Merged
Merged
Conversation
jscheffl
requested review from
bbovenzi, pierrejeambrun and ryanahamilton
as code ownersDecember 31, 2024 13:52
potiuk
commented
Dec 31, 2024
Member
Applied full tests needed to trigger full static checks |
Contributor
That was just the default value for prettier. I'm happy to have it match our rules for python. |
jschefflforce-pushed
the
feature/ui-line-length-110
branch
from
December 31, 2024 16:18
5389526 to
aa370c7Comparepotiuk
approved these changes
Dec 31, 2024
jscheffl
commented
Dec 31, 2024
ContributorAuthor
No short term objection... as not too much activity LGTM (and beat me up if this was too fast) |
This was referenced Jan 1, 2025
HariGS-DB pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
* Change UI source formatting to 110 chars * Fix static checks - re-format all UI code from 80 to 110 chars
got686-yandex pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Change UI source formatting to 110 chars * Fix static checks - re-format all UI code from 80 to 110 chars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Note: I know this PR fails in pre-commit checks but wanted to raise it anyway... based on discussion I'd make it clean)
I noticed that in pre-commit we format all text to 110 chars... for Python code and tooling. Also there was a bit of discussion on the devlist about to change it for smaller screens.
NOTE: The big diff is mainly the re-formatting of all UI source. The impact is caused by the one line change in https://github.com/apache/airflow/pull/45312/files#diff-14e4a70ab8ce4057d209267e534689fe0c3f48658095289169b396cd0c37be51R8
Nevertheless I was wondering why we format the (new) UI code to 80 chars? Is there a reason for this? I'd propose (with this PR) to make it common with the test of the codebase.