Change pre-commit propety(v1) by kyungjunleeme · Pull Request #53636 · apache/airflow

kyungjunleeme · 2025-07-22T13:42:41Z

pre-commit hook only include v1.yaml

it solve ci error in github.
related #53597

It cause error. refer to below image.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

potiuk · 2025-07-22T16:12:44Z

What problem does it solve really ?

kyungjunleeme · 2025-07-23T10:37:38Z

I realized that while I updated the API, I missed the corresponding frontend changes. Unfortunately, I wasn't able to reproduce the issue on my side, but I should have been more careful before submitting the PR. I sincerely apologize for the oversight. I’ll make the necessary adjustments and prepare an updated version for review soon. I also want to acknowledge that I didn’t fully consider how valuable your time as a reviewer is—I'm truly sorry for that.

potiuk · 2025-07-23T13:56:19Z

I realized that while I updated the API, I missed the corresponding frontend changes. Unfortunately, I wasn't able to reproduce the issue on my side, but I should have been more careful before submitting the PR. I sincerely apologize for the oversight. I’ll make the necessary adjustments and prepare an updated version for review soon. I also want to acknowledge that I didn’t fully consider how valuable your time as a reviewer is—I'm truly sorry for that.

No worries - I was just wondering what's wrong there :)

kyungjunleeme · 2025-07-24T07:14:49Z

What problem does it solve really ?

The current files pattern only matches:

^airflow-core/src/airflow/api_fastapi/auth/managers/simple/openapi/v1.*\.yaml$

so it doesn't catch changes like v2-simple-auth-manager-generated.yaml.
I'm planning to update the regex to:

^airflow-core/src/airflow/api_fastapi/auth/managers/simple/openapi/.*\.yaml$

to ensure all OpenAPI changes under the simple/openapi/ directory are properly detected by pre-commit.

There is an issue with the pre-commit scope, which is causing the following failure:

https://github.com/apache/airflow/actions/runs/16489362751/job/46620971120

potiuk · 2025-07-24T12:13:34Z

Cool

potiuk · 2025-07-24T12:13:57Z

Now it makes sense :)

(cherry picked from commit 9d9924e) Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>

github-actions · 2025-07-24T12:14:18Z

Backport successfully created: v3-0-test

Status	Branch	Result
✅	v3-0-test

(cherry picked from commit 9d9924e) Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>

apache#68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (apache#51725), a month after the spec was renamed v1 to v2 (apache#50705), so it has never matched a file - apache#53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either.

#68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (#51725), a month after the spec was renamed v1 to v2 (#50705), so it has never matched a file - #53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either.

…nges (#70643) #68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (#51725), a month after the spec was renamed v1 to v2 (#50705), so it has never matched a file - #53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either. (cherry picked from commit b43a87e) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

…#70643) apache#68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (apache#51725), a month after the spec was renamed v1 to v2 (apache#50705), so it has never matched a file - apache#53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either.

…nges (#70643) #68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (#51725), a month after the spec was renamed v1 to v2 (#50705), so it has never matched a file - #53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either. (cherry picked from commit b43a87e) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

…nges (#70643) (#70672) #68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (#51725), a month after the spec was renamed v1 to v2 (#50705), so it has never matched a file - #53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either. (cherry picked from commit b43a87e) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

kyungjunleeme requested review from ashb, gopidesupavan and potiuk as code owners July 22, 2025 13:42

boring-cyborgBot added area:dev-tools backport-to-v3-0-test labels Jul 22, 2025

kyungjunleeme mentioned this pull request Jul 22, 2025
Change logic in auth with swagger ui #53597
Merged

kyungjunleeme marked this pull request as draft July 23, 2025 10:38

kyungjunleeme force-pushed the fix/ci_static_check_align branch from b5890a3 to 69a1dafCompare July 24, 2025 07:16

kyungjunleeme marked this pull request as ready for review July 24, 2025 07:17

kyungjunleeme force-pushed the fix/ci_static_check_align branch from 69a1daf to 7712f5cCompare July 24, 2025 07:17

kyungjunleeme changed the title ~~Align Ci static Check~~Change pre-commit propety(v1)Jul 24, 2025

CHG: cover v1, v2
5774ab6

kyungjunleeme force-pushed the fix/ci_static_check_align branch from 7712f5c to 5774ab6Compare July 24, 2025 10:26

potiuk approved these changes Jul 24, 2025
View reviewed changes

potiuk merged commit 9d9924e into apache:mainJul 24, 2025
56 checks passed

github-actionsBot pushed a commit that referenced this pull request Jul 24, 2025
[v3-0-test] CHG: cover v1, v2 (#53636)
21c1f5b
(cherry picked from commit 9d9924e) Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>

potiuk pushed a commit that referenced this pull request Jul 24, 2025
[v3-0-test] CHG: cover v1, v2 (#53636) (#53709)
231129f
(cherry picked from commit 9d9924e) Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>

shahar1 mentioned this pull request Jul 28, 2026
Run UI compile checks in CI when only an OpenAPI spec changes #70643
Merged
1 task

github-actionsBot mentioned this pull request Jul 29, 2026
[v3-3-test] Run UI compile checks in CI when only an OpenAPI spec changes (#70643) #70672
Merged

Navigation Menu

Uh oh!

Change pre-commit propety(v1) - #53636

Change pre-commit propety(v1)#53636
potiuk merged 1 commit into
apache:mainfrom
kyungjunleeme:fix/ci_static_check_align

kyungjunleeme commented Jul 22, 2025•
edited
Loading

Uh oh!

potiuk commented Jul 22, 2025

Uh oh!

kyungjunleeme commented Jul 23, 2025

Uh oh!

potiuk commented Jul 23, 2025

Uh oh!

kyungjunleeme commented Jul 24, 2025•
edited
Loading

Uh oh!

Uh oh!

potiuk commented Jul 24, 2025

Uh oh!

potiuk commented Jul 24, 2025

Uh oh!

github-actionsBot commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kyungjunleeme commented Jul 22, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

potiuk commented Jul 22, 2025

Uh oh!

kyungjunleeme commented Jul 23, 2025

Uh oh!

potiuk commented Jul 23, 2025

Uh oh!

kyungjunleeme commented Jul 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

potiuk commented Jul 24, 2025

Uh oh!

potiuk commented Jul 24, 2025

Uh oh!

github-actionsBot commented Jul 24, 2025

Backport successfully created: v3-0-test

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kyungjunleeme commented Jul 22, 2025•
edited
Loading

kyungjunleeme commented Jul 24, 2025•
edited
Loading