Skip to content

[v3-3-test] Run UI compile checks in CI when only an OpenAPI spec changes (#70643) - #70672

Merged
potiuk merged 1 commit into
v3-3-testfrom
backport-b43a87e-v3-3-test
Aug 17, 2026
Merged

[v3-3-test] Run UI compile checks in CI when only an OpenAPI spec changes (#70643)#70672
potiuk merged 1 commit into
v3-3-testfrom
backport-b43a87e-v3-3-test

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

#68919 changed _private_ui.yaml without regenerating the TypeScript client
and CI stayed green: selective checks decide whether to skip the
ts-compile-lint-* hooks from file groups that do not cover the UI codegen
input specs, while the hooks themselves trigger on any yaml under the
openapi directories. The stale client then masked a type error that broke
main for every PR running full static checks. The same gap applied to
v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped
the simple auth manager UI hook. Track the codegen-input specs in their own
file group so spec-only changes run the UI hooks without forcing the full
test matrix, and drop the main UI hook trigger for the simple auth manager
spec: that pattern was copied in when the hook was created (#51725), a
month after the spec was renamed v1 to v2 (#50705), so it has never matched
a file - #53636 fixed the sibling hook's copy but missed this one. The main
UI codegen does not consume that spec either.
(cherry picked from commit b43a87e)

Co-authored-by: Shahar Epstein 60007259+shahar1@users.noreply.github.com

@pierrejeambrun

Copy link
Copy Markdown
Member

@shahar1 Something is off here, I wonder if it's transient or caused by the PR.

…nges (#70643)
#68919 changed _private_ui.yaml without regenerating the TypeScript client
and CI stayed green: selective checks decide whether to skip the
ts-compile-lint-* hooks from file groups that do not cover the UI codegen
input specs, while the hooks themselves trigger on any yaml under the
openapi directories. The stale client then masked a type error that broke
main for every PR running full static checks. The same gap applied to
v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped
the simple auth manager UI hook. Track the codegen-input specs in their own
file group so spec-only changes run the UI hooks without forcing the full
test matrix, and drop the main UI hook trigger for the simple auth manager
spec: that pattern was copied in when the hook was created (#51725), a
month after the spec was renamed v1 to v2 (#50705), so it has never matched
a file - #53636 fixed the sibling hook's copy but missed this one. The main
UI codegen does not consume that spec either.
(cherry picked from commit b43a87e)
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@potiuk
potiukforce-pushed the backport-b43a87e-v3-3-test branch from 7368151 to f8404a8CompareAugust 17, 2026 10:30

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto the current v3-3-test tip; the backport replays cleanly and the tests and prek hooks it touches pass locally against this branch.

Scope-checked for a maintenance branch: this is a bugfix / documentation / dev-tooling change, with no new user-facing behaviour.


Drafted-by: Claude Code (Opus 5) (no human review before posting)

@potiuk
potiuk merged commit 721b13f into v3-3-testAug 17, 2026
115 checks passed
@potiuk
potiuk deleted the backport-b43a87e-v3-3-test branch August 17, 2026 13:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pierrejeambrun@potiuk@Lee-W@shahar1