') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Deferred KubernetesPodOperator pushes XCom on successful execution. by AutomationDev85 · Pull Request #58488 · apache/airflow · GitHub
Skip to content

Deferred KubernetesPodOperator pushes XCom on successful execution. - #58488

Merged
jscheffl merged 1 commit into
apache:mainfrom
boschglobal:feature/enable-kubernetes-pod-operator-xcom-output
Nov 20, 2025
Merged

Deferred KubernetesPodOperator pushes XCom on successful execution.#58488
jscheffl merged 1 commit into
apache:mainfrom
boschglobal:feature/enable-kubernetes-pod-operator-xcom-output

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

Overview

After upgrading to kubernetes provider 10.10.0, XCom was no longer pushed on successful execution of KubernetesPodOperator in deferrable mode. This PR restores XCom propagation for successful deferred runs.

Change Summary

  • Ensure trigger_reentry returns XCom value when do_xcom_push is True and execution succeeds.
  • Extend unit tests to assert XCom is returned in deferrable mode.

Feedback is welcome.

@boring-cyborgboring-cyborgBot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Nov 19, 2025
@jscheffl
jscheffl merged commit 0aa2ea7 into apache:mainNov 20, 2025
96 checks passed
@jscheffljscheffl mentioned this pull request Nov 27, 2025
Closed
62 tasks
johnslavik
johnslavik reviewed Dec 1, 2025
View reviewed changes
Comment threadproviders/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py
Comment on lines +938 to +939
if self.do_xcom_push:
return xcom_sidecar_output

@johnslavikjohnslavikDec 1, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be illegal syntax in a future Python version. We'll need to take that return out of finally.
https://peps.python.org/pep-0765/

@jscheffljschefflDec 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AutomationDev85 the more I revisit the core the more I think this patch was not good. Actually you wanted to push XCom but with this you are masking the exception raise.

Can you re-work? I assume you to manually xcom_push() and then raise in case of error, else return XCom in this way only on success but not in finally.

@AutomationDev85AutomationDev85Dec 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnslavik thanks for identifying this issue!! I created a PR to fix this issue: #58998

@jscheffljschefflDec 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume cause is that the ruff rule https://docs.astral.sh/ruff/rules/return-in-try-except-finally/ (SIM107) is not enabled in the repo, that should have catched this. Will put this on my bucket list to enable... or if somebody else wants to make a PR I assume this is an important check we are missing atm.

@johnslavikjohnslavikDec 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will put this on my bucket list to enable... or if somebody else wants to make a PR I assume this is an important check we are missing atm.

#59019

@potiukpotiukDec 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks @johnslavik !

@jscheffljscheffl mentioned this pull request Dec 1, 2025
Closed
70 tasks
@AutomationDev85AutomationDev85 mentioned this pull request Dec 3, 2025
Merged
@johnslavikjohnslavik mentioned this pull request Dec 3, 2025
Closed
CopilotAI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
@AutomationDev85
KubernetesPodOperator pushes XCom on successful execution. (apache#58488
59db3f5
)
Co-authored-by: AutomationDev85 <AutomationDev85>
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
@AutomationDev85@itayweb
KubernetesPodOperator pushes XCom on successful execution. (apache#58488
2ece8d6
)
Co-authored-by: AutomationDev85 <AutomationDev85>
@jscheffljscheffl mentioned this pull request Dec 23, 2025
Merged
@aaron-y-chenaaron-y-chen mentioned this pull request Jan 5, 2026
Closed
2 tasks
@paultmathewpaultmathew mentioned this pull request May 20, 2026
Merged
This was referenced Jun 3, 2026
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk left review comments
@jscheffljscheffljscheffl approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner
+1 more reviewer
@johnslavikjohnslavikjohnslavik left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:providersprovider:cncf-kubernetesKubernetes (k8s) provider related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AutomationDev85@potiuk@johnslavik@jscheffl