') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add and fix SIM107 and B012 Ruff rule by jscheffl · Pull Request #59770 · apache/airflow · GitHub

Add and fix SIM107 and B012 Ruff rule - #59770

Merged

potiuk merged 2 commits into

apache:mainfrom

jscheffl:bugfix/lint-jumps-in-finally

Dec 26, 2025

jscheffl commented Dec 23, 2025

Contributor

As of comments from @johnslavik (Thanks!) in #58488 detected a bad use of return in finally which should be prevented and PR #59019 did not make it on main this PR is a follow-up to prevent a regression on such problems.

Alongside two occurrences in Celery and CNCF.K8s provider are fixed, I assume for the good.

jscheffl requested review from hussein-awala and jedcunningham as code owners

December 23, 2025 17:54

boring-cyborgBot added area:providers provider:celery provider:cncf-kubernetes labels

johnslavik suggested changes

View reviewed changes

providers/celery/src/airflow/providers/celery/cli/celery_command.py Outdated

jscheffl added 2 commits

December 24, 2025 10:25

Add and fix SIM107 and B012 Ruff rule

c2e2381

Review by@johnslavik

6b53096

jscheffl force-pushed the bugfix/lint-jumps-in-finally branch from ef13ccc to 6b53096Compare

December 24, 2025 09:26

jscheffl requested a review from johnslavik

December 24, 2025 09:26

potiuk approved these changes

View reviewed changes

potiuk merged commit 77a2f1c into apache:main

220 checks passed

amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request

Add and fix SIM107 and B012 Ruff rule (apache#59770)

0221a96

* Add and fix SIM107 and B012 Ruff rule
* Review by @johnslavik

shahar1 mentioned this pull request

Status of testing Providers that were prepared on December 30, 2025 #59952

Closed

54 tasks

Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request

Add and fix SIM107 and B012 Ruff rule (apache#59770)

9df9136

* Add and fix SIM107 and B012 Ruff rule
* Review by @johnslavik

stegololz pushed a commit to stegololz/airflow that referenced this pull request

Add and fix SIM107 and B012 Ruff rule (apache#59770)

f2a2d60

* Add and fix SIM107 and B012 Ruff rule
* Review by @johnslavik

jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request

Add and fix SIM107 and B012 Ruff rule (apache#59770)

c0b6ee7

* Add and fix SIM107 and B012 Ruff rule
* Review by @johnslavik

Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request

Add and fix SIM107 and B012 Ruff rule (apache#59770)

6ce0393

* Add and fix SIM107 and B012 Ruff rule
* Review by @johnslavik

Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request

Add and fix SIM107 and B012 Ruff rule (apache#59770)

bc8d2db

* Add and fix SIM107 and B012 Ruff rule
* Review by @johnslavik

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:celery provider:cncf-kubernetes