Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix asset scheduling for stale DAGs (#59337) - #60022

Merged
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337
Jan 27, 2026
Merged

Fix asset scheduling for stale DAGs (#59337)#60022
Lee-W merged 3 commits into
apache:mainfrom
Jkhall81:fix-stale-dag-asset-scheduling-59337

Conversation

@Jkhall81

Copy link
Copy Markdown
Contributor

fix(assets): queue asset updates for stale DAGs

closes:#59337

Summary

This PR ensures that asset updates are recorded in the AssetDagRunQueue even if a DAG is currently in a "stale" state. By allowing these updates to be queued, DAGs will automatically trigger their missed runs once they are successfully parsed and become healthy again, rather than remaining idle.

Changes

  • Backend: Modified AssetManager.register_asset_change in manager.py to remove is_stale filtering while maintaining is_paused checks across direct, alias, and name/URI asset references.
  • Database: Refined the SQLAlchemy query for asset name/URI references to explicitly exclude paused DAGs for logic consistency.
  • Tests: Added a regression test in test_manager.py that mocks a stale DAG state and verifies it is correctly added to the AssetDagRunQueue upon an asset event.

@Jkhall81

Jkhall81 commented Jan 1, 2026

Copy link
Copy Markdown
ContributorAuthor

I have verified that the logic changes in airflow/assets/manager.py successfully address the issue in #59337 by allowing asset updates to be queued for DAGs even when they are in a 'stale' state.

But there are failures in the following tests:

  • test_asset_listener_on_asset_changed_gets_calls
  • test_no_create_dag_runs_when_dag_disabled[active] (across Postgres, MySQL, and Sqlite)

These are negative tests designed to assert that stale DAGs are ignored. Since that behavior was changed in the PR, these assertions are now failing.

If code change in the PR is accepted, then I can reverse the assertions of these four tests so they align with the fix.

@kaxil
kaxil requested review from Lee-W and uranusjrJanuary 23, 2026 17:49
@Lee-WLee-W self-assigned this Jan 24, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 47ae90c to 2c2dc44CompareJanuary 26, 2026 09:44
Comment threadairflow-core/tests/unit/listeners/test_asset_listener.py Outdated

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase from the latest main and fix a few nitpicks. I'm going to merge it tomorrow if no one objects.

@Lee-WLee-W added backport-to-v3-1-test area:data-aware-scheduling assets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions labels Jan 26, 2026
@Lee-W
Lee-Wforce-pushed the fix-stale-dag-asset-scheduling-59337 branch from 2c2dc44 to 196e862CompareJanuary 26, 2026 10:10
@Lee-W
Lee-W merged commit 73451c5 into apache:mainJan 27, 2026
89 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 73451c5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 27, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit to astronomer/airflow that referenced this pull request Jan 28, 2026
…e#60022)
(cherry picked from commit 73451c5)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Lee-W added a commit that referenced this pull request Jan 28, 2026
…1106)
Co-authored-by: Jason K Hall <106277735+Jkhall81@users.noreply.github.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Fix asset scheduling for stale DAGs (#59337) (#60022)
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajeshamoghrajesh added this to the Airflow 3.1.7 milestone Jan 30, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data-aware-schedulingassets, datasets, AIP-48, AIP-76, AIP-74, Asset Partitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Jkhall81@Lee-W@amoghrajesh