[v3-2-test] Fix boring-cyborg prek hook for dict-form rules by potiuk · Pull Request #65872 · apache/airflow

potiuk · 2026-04-26T13:36:41Z

Summary

Backports the prek-script half of #65386 to fix static checks on
v3-2-test, which broke after #65610 was merged here.

The new backport-to-airflow-ctl-v0-1-test rule introduced by #65610
uses the {paths, targetBranchFilter} object form supported by Boring
Cyborg's upstream (kaxil/boring-cyborg#112). v3-2-test's
scripts/ci/prek/boring_cyborg.py only understood the legacy
list-of-globs form, so it flagged paths and targetBranchFilter as
unused glob patterns and failed the check-boring-cyborg-configuration
hook on every push to v3-2-test.

The .github/boring-cyborg.yml half of #65386 is intentionally not
backported: it converts the backport-to-v3-2-test rule (which lives
on main) — that rule has no analogue here. The existing
backport-to-v3-1-test rule on this branch continues to use the
legacy list form and remains valid.

Test plan

prek run check-boring-cyborg-configuration --all-files passes locally
CI static checks pass

Was generative AI tooling used to co-author this PR?

Yes — Claude Code (Opus 4.7, 1M context)

Generated-by: Claude Code (Opus 4.7, 1M context) following the guidelines

Backport of the prek-script half of apache#65386 to fix static checks on v3-2-test after apache#65610 added a backport-to-airflow-ctl-v0-1-test rule in dict form ({paths, targetBranchFilter}). The legacy script on v3-2-test only understood the flat list-of-globs form, so it flagged `paths` and `targetBranchFilter` as unused glob patterns and failed the check. The .github/boring-cyborg.yml YAML changes from apache#65386 are intentionally omitted: those targeted the `backport-to-v3-2-test` rule that lives on main, which has no analogue on this branch (here it is `backport-to-v3-1-test` and the existing list form continues to work).

On v3-2-test, BulkTaskInstanceService had three pre-existing bugs: 1. `_perform_update` did not pass `map_index` to `_patch_ti_validate_request`, so the validation step looked up the wrong TI (default map_index=-1) and persistence silently no-op'd for mapped task instances. 2. `specific_entity_map` and `all_map_entity_map` used raw `(entity.dag_id, entity.dag_run_id, entity.task_id, ...)` tuples as keys. When `dag_id`/`dag_run_id` came from the path and not the request body, those attributes were `None` on the entity, while keys produced by `_categorize_entities` resolved them via `_extract_task_identifiers`. The resulting key mismatch meant matched task keys never resolved back to an entity, so `_perform_update` was never called and `response.update.success` came back empty. 3. `action_name=action.action` rendered as `'BulkAction.UPDATE'` /`'BulkAction.DELETE'` in authorization error messages because Python's str-enum `__format__` returns the enum repr, not the value. Use `.value` to get "update"/"delete". All three fixes already exist on main; this backport is the minimal diff to bring v3-2-test in line with main for this file. Also includes the following pre-existing v3-2-test fixes that the prek hooks force to land alongside any source change: - Regenerated _private_ui.yaml, schemas.gen.ts and types.gen.ts: generate-openapi-spec caught a description drift on `ExtraMenuItem`. - Added `fpr` to docs/spelling_wordlist.txt: codespell flagged the GPG colons-format `^fpr:` regex tag in dev/README_RELEASE_*.md. Same fix already on main from apache#65501. - Regenerated dev/breeze/doc/images/output_pr_auto-triage.{svg,txt}: the boring-cyborg config update in apache#65872 added the `backport-to-airflow-ctl-v0-1-test` label, which appears in the `breeze pr auto-triage --help` output and changes its hash.

…#65874) On v3-2-test, BulkTaskInstanceService had three pre-existing bugs: 1. `_perform_update` did not pass `map_index` to `_patch_ti_validate_request`, so the validation step looked up the wrong TI (default map_index=-1) and persistence silently no-op'd for mapped task instances. 2. `specific_entity_map` and `all_map_entity_map` used raw `(entity.dag_id, entity.dag_run_id, entity.task_id, ...)` tuples as keys. When `dag_id`/`dag_run_id` came from the path and not the request body, those attributes were `None` on the entity, while keys produced by `_categorize_entities` resolved them via `_extract_task_identifiers`. The resulting key mismatch meant matched task keys never resolved back to an entity, so `_perform_update` was never called and `response.update.success` came back empty. 3. `action_name=action.action` rendered as `'BulkAction.UPDATE'` /`'BulkAction.DELETE'` in authorization error messages because Python's str-enum `__format__` returns the enum repr, not the value. Use `.value` to get "update"/"delete". All three fixes already exist on main; this backport is the minimal diff to bring v3-2-test in line with main for this file. Also includes the following pre-existing v3-2-test fixes that the prek hooks force to land alongside any source change: - Regenerated _private_ui.yaml, schemas.gen.ts and types.gen.ts: generate-openapi-spec caught a description drift on `ExtraMenuItem`. - Added `fpr` to docs/spelling_wordlist.txt: codespell flagged the GPG colons-format `^fpr:` regex tag in dev/README_RELEASE_*.md. Same fix already on main from #65501. - Regenerated dev/breeze/doc/images/output_pr_auto-triage.{svg,txt}: the boring-cyborg config update in #65872 added the `backport-to-airflow-ctl-v0-1-test` label, which appears in the `breeze pr auto-triage --help` output and changes its hash.

…#65872) Backport of the prek-script half of #65386 to fix static checks on v3-2-test after #65610 added a backport-to-airflow-ctl-v0-1-test rule in dict form ({paths, targetBranchFilter}). The legacy script on v3-2-test only understood the flat list-of-globs form, so it flagged `paths` and `targetBranchFilter` as unused glob patterns and failed the check. The .github/boring-cyborg.yml YAML changes from #65386 are intentionally omitted: those targeted the `backport-to-v3-2-test` rule that lives on main, which has no analogue on this branch (here it is `backport-to-v3-1-test` and the existing list form continues to work).

…#65874) On v3-2-test, BulkTaskInstanceService had three pre-existing bugs: 1. `_perform_update` did not pass `map_index` to `_patch_ti_validate_request`, so the validation step looked up the wrong TI (default map_index=-1) and persistence silently no-op'd for mapped task instances. 2. `specific_entity_map` and `all_map_entity_map` used raw `(entity.dag_id, entity.dag_run_id, entity.task_id, ...)` tuples as keys. When `dag_id`/`dag_run_id` came from the path and not the request body, those attributes were `None` on the entity, while keys produced by `_categorize_entities` resolved them via `_extract_task_identifiers`. The resulting key mismatch meant matched task keys never resolved back to an entity, so `_perform_update` was never called and `response.update.success` came back empty. 3. `action_name=action.action` rendered as `'BulkAction.UPDATE'` /`'BulkAction.DELETE'` in authorization error messages because Python's str-enum `__format__` returns the enum repr, not the value. Use `.value` to get "update"/"delete". All three fixes already exist on main; this backport is the minimal diff to bring v3-2-test in line with main for this file. Also includes the following pre-existing v3-2-test fixes that the prek hooks force to land alongside any source change: - Regenerated _private_ui.yaml, schemas.gen.ts and types.gen.ts: generate-openapi-spec caught a description drift on `ExtraMenuItem`. - Added `fpr` to docs/spelling_wordlist.txt: codespell flagged the GPG colons-format `^fpr:` regex tag in dev/README_RELEASE_*.md. Same fix already on main from #65501. - Regenerated dev/breeze/doc/images/output_pr_auto-triage.{svg,txt}: the boring-cyborg config update in #65872 added the `backport-to-airflow-ctl-v0-1-test` label, which appears in the `breeze pr auto-triage --help` output and changes its hash.

…#65872) Backport of the prek-script half of #65386 to fix static checks on v3-2-test after #65610 added a backport-to-airflow-ctl-v0-1-test rule in dict form ({paths, targetBranchFilter}). The legacy script on v3-2-test only understood the flat list-of-globs form, so it flagged `paths` and `targetBranchFilter` as unused glob patterns and failed the check. The .github/boring-cyborg.yml YAML changes from #65386 are intentionally omitted: those targeted the `backport-to-v3-2-test` rule that lives on main, which has no analogue on this branch (here it is `backport-to-v3-1-test` and the existing list form continues to work).

…#65874) On v3-2-test, BulkTaskInstanceService had three pre-existing bugs: 1. `_perform_update` did not pass `map_index` to `_patch_ti_validate_request`, so the validation step looked up the wrong TI (default map_index=-1) and persistence silently no-op'd for mapped task instances. 2. `specific_entity_map` and `all_map_entity_map` used raw `(entity.dag_id, entity.dag_run_id, entity.task_id, ...)` tuples as keys. When `dag_id`/`dag_run_id` came from the path and not the request body, those attributes were `None` on the entity, while keys produced by `_categorize_entities` resolved them via `_extract_task_identifiers`. The resulting key mismatch meant matched task keys never resolved back to an entity, so `_perform_update` was never called and `response.update.success` came back empty. 3. `action_name=action.action` rendered as `'BulkAction.UPDATE'` /`'BulkAction.DELETE'` in authorization error messages because Python's str-enum `__format__` returns the enum repr, not the value. Use `.value` to get "update"/"delete". All three fixes already exist on main; this backport is the minimal diff to bring v3-2-test in line with main for this file. Also includes the following pre-existing v3-2-test fixes that the prek hooks force to land alongside any source change: - Regenerated _private_ui.yaml, schemas.gen.ts and types.gen.ts: generate-openapi-spec caught a description drift on `ExtraMenuItem`. - Added `fpr` to docs/spelling_wordlist.txt: codespell flagged the GPG colons-format `^fpr:` regex tag in dev/README_RELEASE_*.md. Same fix already on main from #65501. - Regenerated dev/breeze/doc/images/output_pr_auto-triage.{svg,txt}: the boring-cyborg config update in #65872 added the `backport-to-airflow-ctl-v0-1-test` label, which appears in the `breeze pr auto-triage --help` output and changes its hash.

potiuk · 2026-04-26T13:36:41Z