Uh oh!
There was an error while loading. Please reload this page.
Rename task_store/asset_store to task_state_store/asset_state_store - #68438
Conversation
ashb
left a comment
There was a problem hiding this comment.
I have only skimmed and spot checked this, so there is a change that we've picked up something unexpected in (what I assume was) the find+replace op.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vincbeck
left a comment
There was a problem hiding this comment.
Partially went through the code but I agree with the intent/change
amoghrajesh
commented
Jun 13, 2026
The failures are unrelated, rebasing it now |
jscheffl
left a comment
There was a problem hiding this comment.
"mega rename" sounds cool - and it is! LGTM so that we have a better naming in 3.3.0!
amoghrajesh
commented
Jun 14, 2026
Thanks for reviews all, merging this one now. |
Uh oh!
There was an error while loading. Please reload this page.
Backport failed to create: airflow-ctl/v0-1-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 74a52cf airflow-ctl/v0-1-testThis should apply the commit to the airflow-ctl/v0-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
jscheffl
commented
Jun 14, 2026
@amoghrajesh Noticed that my German translation catch-up now had new gaps as you renamed the new language keys. I reworked my PR (#68356) but I assume a lot of other parallel running translation PRs were outdated on the new keys due to the late change. Does it make sense to bulk-rename already existing translations on main or do the translations need to change in your view adjusting to new key? |
Was generative AI tooling used to co-author this PR?
What
Renames
task_store/asset_storetotask_state_store/asset_state_storeacross the codebase. This is a purely mechanical rename, no logic, behaviour, or API contract changes.Why
@ashb flagged the name
AssetStoreas a significant naming issue: it implies storing actual asset data (potentially GBs of files/objects), whereas these stores hold lightweight state metadata such as job IDs, watermarks, cursors, coordination tokens. The suffixStateStoremakes the intent unambiguous.Proposed change
Rename everything to
TaskStateStore/AssetStateStoreto make the intent clear. Scope of the rename:TaskStoreModel->TaskStateStoreModel,AssetStoreModel→AssetStateStoreModelMetastoreStoreBackend->MetastoreStateStoreBackend/store->/state-storecleanup-task-store->cleanup-task-state-storeTaskStateStoreOperations,AssetStateStoreOperations, context keystask_state_store/asset_state_store, comms modelsTesting
Most of the testing here is for sanity purpose
(Since these use public APIs, we should be good)
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.