Uh oh!
There was an error while loading. Please reload this page.
Do not leak threads from InProcessExecutionAPI - #68840
Merged
Merged
Conversation
Through `a2wsgi.ASGIMiddleware`, the `InProcessExecutionAPI` was leaking a daemon thread per instance, used by `a2wsgi` to run an asyncio event loop. This commit moves management of that background thread into `InProcessExecutionAPI`, and adds a finalizer so that the thread is stopped when the execution API instance is garbage collected.
ashb
approved these changes
Jun 22, 2026
Uh oh!
There was an error while loading. Please reload this page.
ephraimbuddy pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 22, 2026
Through `a2wsgi.ASGIMiddleware`, the `InProcessExecutionAPI` was leaking a daemon thread per instance, used by `a2wsgi` to run an asyncio event loop. This commit moves management of that background thread into `InProcessExecutionAPI`, and adds a finalizer so that the thread is stopped when the execution API instance is garbage collected.
1 task
This was referenced Jun 22, 2026
o-nikolas pushed a commit
that referenced
this pull request
Jun 23, 2026
#68865) * Fix in-process Execution API loop stopped while transport still in use #68840 moved the InProcessExecutionAPI background event-loop + thread cleanup into a weakref.finalize keyed on the InProcessExecutionAPI instance. But callers build a sync Client from InProcessExecutionAPI().transport and discard the factory object, so the instance is garbage-collected while the transport is still in use. The finalizer then stops the loop, and every subsequent request hangs on the dead loop -- surfacing as Timeout failures across the Dag-processor and triggerer in-process API tests on main (Error while closing in-process execution API lifespan -> TimeoutError). Key the finalizer on the returned WSGI transport instead of the factory instance, so loop/thread/lifespan teardown happens when the transport (which the Client holds) is collected, not when the throwaway factory is. Verified locally: test_processor.py::test_top_level_variable_set and test_top_level_variable_access_not_found now pass (previously hung to timeout). * Test transport-tied lifecycle for in-process Execution API Rewrite test_in_process_execution_api_teardown as test_in_process_execution_api_transport_lifecycle: assert that dropping the factory instance leaves the loop running while the transport is held, and only dropping the transport stops the loop + joins the daemon thread. This fails against finalizing on the instance (the regression) and passes with the finalizer keyed on the transport. Verified locally: 1 passed in 11.58s. --------- Co-authored-by: Sean Ghaeli <ghaeli@amazon.com>
cetingokhan pushed a commit
to cetingokhan/airflow
that referenced
this pull request
Jun 24, 2026
Through `a2wsgi.ASGIMiddleware`, the `InProcessExecutionAPI` was leaking a daemon thread per instance, used by `a2wsgi` to run an asyncio event loop. This commit moves management of that background thread into `InProcessExecutionAPI`, and adds a finalizer so that the thread is stopped when the execution API instance is garbage collected.
cetingokhan pushed a commit
to cetingokhan/airflow
that referenced
this pull request
Jun 24, 2026
apache#68865) * Fix in-process Execution API loop stopped while transport still in use apache#68840 moved the InProcessExecutionAPI background event-loop + thread cleanup into a weakref.finalize keyed on the InProcessExecutionAPI instance. But callers build a sync Client from InProcessExecutionAPI().transport and discard the factory object, so the instance is garbage-collected while the transport is still in use. The finalizer then stops the loop, and every subsequent request hangs on the dead loop -- surfacing as Timeout failures across the Dag-processor and triggerer in-process API tests on main (Error while closing in-process execution API lifespan -> TimeoutError). Key the finalizer on the returned WSGI transport instead of the factory instance, so loop/thread/lifespan teardown happens when the transport (which the Client holds) is collected, not when the throwaway factory is. Verified locally: test_processor.py::test_top_level_variable_set and test_top_level_variable_access_not_found now pass (previously hung to timeout). * Test transport-tied lifecycle for in-process Execution API Rewrite test_in_process_execution_api_teardown as test_in_process_execution_api_transport_lifecycle: assert that dropping the factory instance leaves the loop running while the transport is held, and only dropping the transport stops the loop + joins the daemon thread. This fails against finalizing on the instance (the regression) and passes with the finalizer keyed on the transport. Verified locally: 1 passed in 11.58s. --------- Co-authored-by: Sean Ghaeli <ghaeli@amazon.com>
ashb pushed a commit
that referenced
this pull request
Jun 25, 2026
PR #68840 fixed an issue where exceptions thrown by the FastAPI lifecycle hook were swallowed. In doing so, it exposed a pre-existing problem where the lifecycle hook couldn't run when the JWT secret was not provided. As the `InProcessExecutionAPI` overrides auth, it doesn't need a JWT secret, and we certainly don't want to start crashing processes that previously ran fine as a result of a missing secret that we don't need. This commit stubs out the registered `JWTValidator` in the FastAPI app created for the `InProcessExecutionAPI`. This is done in an isolated services registry to ensure we don't leak this into any real app instantiations.
ashb pushed a commit
that referenced
this pull request
Jun 25, 2026
…onAPI` (#68980) (#68982) PR #68840 fixed an issue where exceptions thrown by the FastAPI lifecycle hook were swallowed. In doing so, it exposed a pre-existing problem where the lifecycle hook couldn't run when the JWT secret was not provided. As the `InProcessExecutionAPI` overrides auth, it doesn't need a JWT secret, and we certainly don't want to start crashing processes that previously ran fine as a result of a missing secret that we don't need. This commit stubs out the registered `JWTValidator` in the FastAPI app created for the `InProcessExecutionAPI`. This is done in an isolated services registry to ensure we don't leak this into any real app instantiations. (cherry picked from commit e886dfd) Co-authored-by: Nick Stenning <nick@whiteink.com>
karenbraganz pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
…he#68980) PR apache#68840 fixed an issue where exceptions thrown by the FastAPI lifecycle hook were swallowed. In doing so, it exposed a pre-existing problem where the lifecycle hook couldn't run when the JWT secret was not provided. As the `InProcessExecutionAPI` overrides auth, it doesn't need a JWT secret, and we certainly don't want to start crashing processes that previously ran fine as a result of a missing secret that we don't need. This commit stubs out the registered `JWTValidator` in the FastAPI app created for the `InProcessExecutionAPI`. This is done in an isolated services registry to ensure we don't leak this into any real app instantiations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through
a2wsgi.ASGIMiddleware, theInProcessExecutionAPIwas leaking a daemon thread per instance, used bya2wsgito run an asyncio event loop.This commit moves management of that background thread into
InProcessExecutionAPI, and adds a finalizer so that the thread is stopped when the execution API instance is garbage collected.Note: This also changes how we execute the FastAPI app's lifecycle hooks so that they are required to complete before the
transportproperty returns a value. I think this is probably the correct behaviour anyway, but the change is in this PR to make it simpler to run the CMclosehook on teardown.