Uh oh!
There was an error while loading. Please reload this page.
Revert "Do not leak threads from InProcessExecutionAPI (#68840)" to unblock main - #68864
Closed
seanghaeli wants to merge 1 commit into
Closed
Revert "Do not leak threads from InProcessExecutionAPI (#68840)" to unblock main#68864seanghaeli wants to merge 1 commit into
seanghaeli wants to merge 1 commit into
Conversation
This reverts commit a52be75.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #68840.
#68840 ("Do not leak threads from
InProcessExecutionAPI") moved the background event-loop + thread cleanup into aweakref.finalizekeyed on theInProcessExecutionAPIinstance. Callers build a syncClientfromInProcessExecutionAPI().transportand drop the factory object, so the instance is garbage-collected while the transport is still in use — the finalizer then stops the loop and every later request hangs on the dead loop.This is currently red on
main: the latest scheduled canary fails ~24/31 serialization-core jobs withError while closing in-process execution API lifespan -> TimeoutError(e.g.test_processor.py::TestDagFileProcessor::test_top_level_variable_*,test_triggerer_job.py::test_trigger_can_*). It blocks CI on every open PR that touches core test scope.This is a temporary revert to unblock
main. The proper forward-fix (finalize on the transport rather than the instance) is @potiuk's #68855, which should supersede this once it is green and reviewed. Reverting first restores a greenmainfor everyone in the meantime; the original thread-leak #68840 addresses can be re-landed via #68855.related: #68840, #68855
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines