Uh oh!
There was an error while loading. Please reload this page.
Make test_cli_run_time tolerant of slow/cold CI runners - #68968
Merged
potiuk merged 1 commit intoJun 26, 2026
Conversation
potiukforce-pushed
the
harden-flaky-cli-time-and-provider-scan-tests
branch
from
June 25, 2026 07:56
70fa63f to
94b7396CompareThe test asserted the best of 3 "airflow --help" startup samples was under a tight 5s bound. On a loaded or cold runner (e.g. the Pendulum2 special-test job, which runs in a freshly rebuilt env) the whole-provider-load startup consistently sits just over it -- the best of 3 was 5.49s -- even though nothing regressed. Take the min of more samples and loosen the threshold so the test still guards against gross startup regressions without flaking on small fluctuations.
potiukforce-pushed
the
harden-flaky-cli-time-and-provider-scan-tests
branch
from
June 25, 2026 08:14
94b7396 to
3065b80Comparebugraoz93
approved these changes
Jun 25, 2026
Contributor
Hi maintainer, this PR was merged without a milestone set.
|
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk added a commit
that referenced
this pull request
Jun 26, 2026
…68968) (#69053) The test asserted the best of 3 "airflow --help" startup samples was under a tight 5s bound. On a loaded or cold runner (e.g. the Pendulum2 special-test job, which runs in a freshly rebuilt env) the whole-provider-load startup consistently sits just over it -- the best of 3 was 5.49s -- even though nothing regressed. Take the min of more samples and loosen the threshold so the test still guards against gross startup regressions without flaking on small fluctuations. (cherry picked from commit b24194f) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
karenbraganz pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
The test asserted the best of 3 "airflow --help" startup samples was under a tight 5s bound. On a loaded or cold runner (e.g. the Pendulum2 special-test job, which runs in a freshly rebuilt env) the whole-provider-load startup consistently sits just over it -- the best of 3 was 5.49s -- even though nothing regressed. Take the min of more samples and loosen the threshold so the test still guards against gross startup regressions without flaking on small fluctuations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_cli_run_timeasserted the best of 3airflow --helpstartup samples was under a tight 5s bound. On a loaded or cold runner — e.g. the Pendulum2 special-test job (Tests (AMD), v3-3-test), which runs in a freshly rebuilt env — the whole-provider-load startup consistently sits just over it (best of 3 was 5.49s), even though nothing regressed.Take the min of 5 samples and loosen the threshold to 8s, so the test still guards against gross startup regressions without flaking on small fluctuations.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines