Uh oh!
There was an error while loading. Please reload this page.
[v3-3-test] Make test_cli_run_time tolerant of slow/cold CI runners (#68968) - #69053
Merged
Conversation
…68968) The test asserted the best of 3 "airflow --help" startup samples was under a tight 5s bound. On a loaded or cold runner (e.g. the Pendulum2 special-test job, which runs in a freshly rebuilt env) the whole-provider-load startup consistently sits just over it -- the best of 3 was 5.49s -- even though nothing regressed. Take the min of more samples and loosen the threshold so the test still guards against gross startup regressions without flaking on small fluctuations. (cherry picked from commit b24194f) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task
potiuk
marked this pull request as ready for review
June 26, 2026 18:51
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test asserted the best of 3 "airflow --help" startup samples was under a
tight 5s bound. On a loaded or cold runner (e.g. the Pendulum2 special-test job,
which runs in a freshly rebuilt env) the whole-provider-load startup consistently
sits just over it -- the best of 3 was 5.49s -- even though nothing regressed.
Take the min of more samples and loosen the threshold so the test still guards
against gross startup regressions without flaking on small fluctuations.
(cherry picked from commit b24194f)
Co-authored-by: Jarek Potiuk jarek@potiuk.com