Uh oh!
There was an error while loading. Please reload this page.
Validate Dag and task IDs in the ts-sdk task registry - #69400
Merged
Conversation
guan404mingforce-pushed
the
ts-chore
branch
2 times, most recently
from
July 5, 2026 05:14
d3869bd to
97db89fCompareguan404ming
marked this pull request as ready for review
July 5, 2026 06:38
jason810496
approved these changes
Jul 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
I'm going to merge this. Feel free to open issue/pr to refine this, thanks! |
Uh oh!
There was an error while loading. Please reload this page.
1 task
joshuabvarghese pushed a commit
to joshuabvarghese/airflow
that referenced
this pull request
Jul 16, 2026
* Validate Dag and task IDs in the ts-sdk task registry * Validate Dag and task ID length in the ts-sdk task registry
1 task
1 task
Andrushika added a commit
to Andrushika/airflow
that referenced
this pull request
Aug 19, 2026
The throwing check from apache#69400, moved to manifest build time by apache#71144, still fails packing outright when the client-side ID rules drift from the server. Follow the direction settled in apache#69965: warn at build time, let the server validate authoritatively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ts-sdk task registry only rejected empty IDs, so a
dagId/taskIdcontaining characters that a Pythondag_id/task_idcan never hold (whitespace,/,@, ...) was accepted at registration but could never match a real task at runtime, leaving a silently dead handler.How
dagId/taskIdat registration against the Python task-SDKKEY_REGEX(Unicode word characters, dashes, dots) so invalid IDs fail fast.Was generative AI tooling used to co-author this PR?
Claude Code with Opus 4.8
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.