Uh oh!
There was an error while loading. Please reload this page.
Warn on suspicious Dag and task IDs at TS SDK build time - #70993
Merged
jason810496 merged 2 commits intoAug 20, 2026
Conversation
Andrushika
commented
Aug 6, 2026
ContributorAuthor
Hi @jason810496 could you please take a look if you have time? Thanks a lot! |
1 task
jason810496
left a comment
Member
There was a problem hiding this comment.
Sure! I prefer to wait until #71144 get merged first, then rebase this one on top of it, thanks.
The throwing check from apache#69400, moved to manifest build time by apache#71144, still fails packing outright when the client-side ID rules drift from the server. Follow the direction settled in apache#69965: warn at build time, let the server validate authoritatively.
Andrushikaforce-pushed
the
ts-sdk-suspicious-id-warnings
branch
from
August 19, 2026 10:45
2977fc2 to
897a0c1CompareAndrushika
commented
Aug 19, 2026
ContributorAuthor
Rebased, thanks! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
A numeric dagId becomes a string object key in the manifest while the registry Map keeps the number, so the handler can never match at runtime and the warning path cannot see it. Empty task ids violate the bundle metadata schema's minLength. Both are client-side type and schema defects rather than server rules that could drift, so they fail the pack instead of warning.
jason810496
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ts-sdk has validated Dag and task IDs by throwing at registration since #69400. The review in #69965 settled on best-effort build time warnings for all SDKs instead, so a stale client-side rule cannot block packing or task runs.
What
airflow-ts-packnow warns on invalid IDs (over 250 chars, bad characters,..) during build time, and still packs.The task registry keeps only the non-empty check. ID length is counted in code points now, since
.lengthcounts astral characters twice.related: #69400, #69965, #69937
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines