') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix the deadline_reference decorator's no-parentheses form by ferruzzi · Pull Request #70708 · apache/airflow · GitHub
Skip to content

Fix the deadline_reference decorator's no-parentheses form - #70708

Merged
vatsrahul1001 merged 3 commits into
apache:mainfrom
aws-mwaa:ferruzzi/deadline-reference/decorator-fixes
Aug 3, 2026
Merged

Fix the deadline_reference decorator's no-parentheses form#70708
vatsrahul1001 merged 3 commits into
apache:mainfrom
aws-mwaa:ferruzzi/deadline-reference/decorator-fixes

Conversation

@ferruzzi

@ferruzziferruzzi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Found a couple issues with the @deadline_reference decorator while working on my Summit workshop.

Docs implied that you could use @deadline_reference without parentheses, as was intended behavior, but using it that way would cause a TypeError (without a particularly helpful message) later when it was called. This PR fixes support for the non-paren version, adds a clearer error message for a related instantiation issue, and cleans up the documentation a little to improve clarity.

This is an additive fix, anything that was working before should still work unchanged.

Was generative AI tooling used to co-author this PR?
  • [ x ] Yes (please specify the tool below)

Generated-by: [Kiro-CLI (Claude Opus 5)] following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@ferruzzi
Fix the deadline_reference decorator's no-parenthesis form
94b7d8a
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
@ferruzziferruzzi added this to the Airflow 3.3.1 milestone Jul 29, 2026
@ferruzzi
ferruzzi requested a review from vincbeckJuly 29, 2026 23:07
@ferruzziferruzzi mentioned this pull request Jul 29, 2026
Open
1 task
o-nikolas
o-nikolas approved these changes Jul 30, 2026
View reviewed changes
Comment threadairflow-core/newsfragments/70708.bugfix.rst
@vatsrahul1001vatsrahul1001 added the backport-to-v3-3-test Backport to v3-3-test label Jul 30, 2026
@vatsrahul1001
vatsrahul1001 merged commit 8541668 into apache:mainAug 3, 2026
107 checks passed
@github-actions

github-actionsBot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
✅v3-3-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request Aug 4, 2026
@github-actions@ferruzzi
[v3-3-test] Fix the deadline_reference decorator's no-parentheses form (
15509f9
#70708) (#70966)
* Fix the deadline_reference decorator's no-parenthesis form
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
* bugfix newsfragment
* sphynx riddles
(cherry picked from commit 8541668)
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
@github-actions@ferruzzi@vatsrahul1001
[v3-3-test] Fix the deadline_reference decorator's no-parentheses form (
48c206c
#70708) (#70966)
* Fix the deadline_reference decorator's no-parenthesis form
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
* bugfix newsfragment
* sphynx riddles
(cherry picked from commit 8541668)
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
@ferruzzi@dabla
Fix the deadline_reference decorator's no-parentheses form (apache#70708
eda2232
)
* Fix the deadline_reference decorator's no-parenthesis form
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
* bugfix newsfragment
* sphynx riddles
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@vincbeckvincbeckvincbeck approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees

No one assigned

Labels

area:deadline-alertsAIP-86 (former AIP-57)area:task-sdkbackport-to-v3-3-testBackport to v3-3-testkind:documentation

Projects

None yet

Milestone

Airflow 3.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ferruzzi@o-nikolas@vincbeck@vatsrahul1001