') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [v3-3-test] Fix the deadline_reference decorator's no-parentheses form (#70708) by github-actions[bot] · Pull Request #70966 · apache/airflow · GitHub
Skip to content

[v3-3-test] Fix the deadline_reference decorator's no-parentheses form (#70708) - #70966

Merged
vatsrahul1001 merged 1 commit into
v3-3-testfrom
backport-8541668-v3-3-test
Aug 4, 2026
Merged

[v3-3-test] Fix the deadline_reference decorator's no-parentheses form (#70708)#70966
vatsrahul1001 merged 1 commit into
v3-3-testfrom
backport-8541668-v3-3-test

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
  • Fix the deadline_reference decorator's no-parenthesis form

Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.

  • bugfix newsfragment

  • sphynx riddles
    (cherry picked from commit 8541668)

Co-authored-by: D. Ferruzzi ferruzzi@amazon.com

@ferruzziYour friendly bot
[v3-3-test] Fix the deadline_reference decorator's no-parentheses form (
f5f5454
#70708)
* Fix the deadline_reference decorator's no-parenthesis form
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
* bugfix newsfragment
* sphynx riddles
(cherry picked from commit 8541668)
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 3, 2026
Merged
@vatsrahul1001
vatsrahul1001 marked this pull request as ready for review August 3, 2026 08:43
@vatsrahul1001vatsrahul1001 added this to the Airflow 3.3.1 milestone Aug 4, 2026
@vatsrahul1001vatsrahul1001 added the type:bug-fix Changelog: Bug Fixes label Aug 4, 2026
@vatsrahul1001
vatsrahul1001 merged commit 15509f9 into v3-3-testAug 4, 2026
166 of 194 checks passed
@vatsrahul1001
vatsrahul1001 deleted the backport-8541668-v3-3-test branch August 4, 2026 05:38
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
@github-actions@ferruzzi@vatsrahul1001
[v3-3-test] Fix the deadline_reference decorator's no-parentheses form (
48c206c
#70708) (#70966)
* Fix the deadline_reference decorator's no-parenthesis form
Used bare, the decorator silently rebound the decorated class to the inner decorator function and skipped registration entirely, surfacing later as an unrelated TypeError with an unhelpful message. Accept both forms, add clearer error messaging when a reference cannot be instantiated, and clarify the related docs.
* bugfix newsfragment
* sphynx riddles
(cherry picked from commit 8541668)
Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
@vatsrahul1001vatsrahul1001 mentioned this pull request Aug 7, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees

No one assigned

Labels

area:deadline-alertsAIP-86 (former AIP-57)area:task-sdkkind:documentationtype:bug-fixChangelog: Bug Fixes

Projects

None yet

Milestone

Airflow 3.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@vatsrahul1001@ferruzzi