[v3-3-test] Convert check-sdk-imports to capture occurences than files (#71212) by github-actions[bot] · Pull Request #71398 · apache/airflow

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

github-actions · 2026-08-11T03:58:32Z

(cherry picked from commit d8cfc95)

Co-authored-by: Amogh Desai amoghrajesh1999@gmail.com

* Extract common AllowListManager base class for prek hooks The allowlist load/save/generate/cleanup logic was duplicated across check_new_airflow_exception_usage.py and check_provide_session_kwargs.py. This consolidates the shared pattern into an abstract AllowListManager in common_prek_utils.py, with subclasses providing only iter_files() and count_occurrences(). * Move check loop and parse into AllowlistManager base class The initial extraction left the scan/tighten/report loop duplicated in both hook scripts and exposed `parse` as a staticmethod that silently ignored the instance's `repo_root`. - Convert `parse` from `@staticmethod` to instance method so it always uses `self.repo_root` (fixes the latent footgun where `_parse_tracked_allowlist` called parse unbound). - Hoist the check loop into `AllowlistManager.check()` with `violation_panel_text()` (abstract) and `format_violation_details()` (overridable) hooks — both `_check_*` wrappers are now one-liners. - Fix naming: `AllowListManager` → `AllowlistManager` to match the subclass convention used throughout. - Add test coverage for `check_new_airflow_exception_usage.py`. (cherry picked from commit 7e47a52)

#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk

Rebased onto the current v3-3-test tip. Two things this branch needed beyond a plain cherry-pick:

The hook depends on AllowlistManager, introduced by #69327 and never backported, so that commit rides along as a prerequisite. Without it the script does not import.
generated/known_sdk_imports_in_core.txt came over with main's occurrence counts; the hook tightened two entries to this branch's actual counts (dag_processing/processor.py, jobs/triggerer_job_runner.py).

The prek script tests pass and the hook converges clean on this branch.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

boring-cyborgBot added the area:dev-tools label Aug 11, 2026

github-actionsBot mentioned this pull request Aug 11, 2026
Convert check-sdk-imports to capture occurences than files #71212
Merged
1 task

vatsrahul1001 force-pushed the v3-3-test branch from 7f613ec to a4b4c61Compare August 13, 2026 08:08

vatsrahul1001 force-pushed the backport-d8cfc95-v3-3-test branch from 135f3bd to 0772378Compare August 13, 2026 08:18

jason810496and others added 2 commits August 17, 2026 13:58

[v3-3-test] Convert check-sdk-imports to capture occurences than files (
213c22a
#71212) (cherry picked from commit d8cfc95) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

potiuk marked this pull request as ready for review August 17, 2026 12:18

potiuk force-pushed the backport-d8cfc95-v3-3-test branch from 0772378 to 213c22aCompare August 17, 2026 12:18

potiuk requested review from amoghrajesh, ashb, bugraoz93, gopidesupavan, jason810496, jscheffl and potiuk as code owners August 17, 2026 12:18

potiuk approved these changes Aug 17, 2026
View reviewed changes

potiuk merged commit a75b7cd into v3-3-testAug 17, 2026
66 of 67 checks passed

potiuk deleted the backport-d8cfc95-v3-3-test branch August 17, 2026 15:57