Describe the bug, including details regarding any error messages, version, and platform.
Commit c8240bd introduced use of simdjson::fractured_json_options and simdjson::fractured_json_string (commit 06e3b9a later moved that).
These APIs are available starting with simdjson 4.3.0,
but ARROW_SIMDJSON_REQUIRED_VERSION is still set to 4.0.0
| set(ARROW_SIMDJSON_REQUIRED_VERSION "4.0.0") |
CMake may accept system simdjson 4.2.3 install and fail:
[2/800] Building CXX object src/arrow/CMake.../arrow_util.dir/util/simdjson_internal.cc.FAILED: [code=1] src/arrow/CMakeFiles/arrow_util.dir/util/simdjson_internal.cc.o ... In file included from ...cpp/src/arrow/util/simdjson_internal.cc:18:...cpp/src/arrow/util/simdjson_internal.h:94:23: error: no type named 'fractured_json_options' in namespace 'simdjson' 94 | const simdjson::fractured_json_options& options = {}) const; | ~~~~~~~~~~^...cpp/src/arrow/util/simdjson_internal.cc:353:21: error: no type named 'fractured_json_options' in namespace 'simdjson' 353 | const simdjson::fractured_json_options& options) const { | ~~~~~~~~~~^...cpp/src/arrow/util/simdjson_internal.cc:355:20: error: no member named 'fractured_json_string' in namespace 'simdjson' 355 | return simdjson::fractured_json_string(json, options); | ~~~~~~~~~~^3 errors generated.[3/800] Building CXX object src/arrow/CMake...ation.dir/integration/json_integration.cc.FAILED: [code=1] src/arrow/CMakeFiles/arrow_integration.dir/integration/json_integration.cc.o ...This was reproduced on macOS with system simdjson 4.2.3.
Builds using bundled simdjson 4.6.4 or Conda simdjson 4.6.4 are not affected
| ARROW_SIMDJSON_BUILD_VERSION=v4.6.4 |
Component(s)
C++
Describe the bug, including details regarding any error messages, version, and platform.
Commit c8240bd introduced use of
simdjson::fractured_json_optionsandsimdjson::fractured_json_string(commit 06e3b9a later moved that).These APIs are available starting with simdjson 4.3.0,
but
ARROW_SIMDJSON_REQUIRED_VERSIONis still set to4.0.0arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake
Line 2855 in a62870c
CMake may accept system simdjson 4.2.3 install and fail:
This was reproduced on macOS with system simdjson 4.2.3.
Builds using bundled simdjson 4.6.4 or Conda simdjson 4.6.4 are not affected
arrow/cpp/thirdparty/versions.txt
Line 105 in a4e3909
Component(s)
C++